close
The Wayback Machine - https://web.archive.org/web/20200523155448/https://github.com/zeit/hyper/issues/3443
Skip to content

/ hyper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keymap to open hamburger menu without using the mouse #3443

Open
gwojan opened this issue Jan 25, 2019 · 13 comments
Open

Add keymap to open hamburger menu without using the mouse #3443

gwojan opened this issue Jan 25, 2019 · 13 comments
Labels
good first issue help wanted 🎨 Type: Enhancement

Comments

@gwojan
Copy link

@gwojan gwojan commented Jan 25, 2019

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10, 1803
  • Hyper.app version: hyper 3.0.0-canary.6 (canary)

Issue

I would really like to be able to open the hamburger menu from the keyboard. I have checked the default mappings for hyper and don't see anything related to the hamburger menu.
@Stanzilla
Copy link
Collaborator

@Stanzilla Stanzilla commented Jan 25, 2019

Should be the ALT key on Windows if it gets added
@doniyor2109
Copy link
Contributor

@doniyor2109 doniyor2109 commented Jan 26, 2019

Hi. Can I work on this issue?
@Stanzilla
Copy link
Collaborator

@Stanzilla Stanzilla commented Jan 26, 2019

Sure, go ahead :)
@doniyor2109 doniyor2109 mentioned this issue Jan 26, 2019
Merged
@doniyor2109
Copy link
Contributor

@doniyor2109 doniyor2109 commented Jan 26, 2019

@Stanzilla Should we add hotkey for linux?
@Stanzilla
Copy link
Collaborator

@Stanzilla Stanzilla commented Jan 26, 2019

I'm not familiar with the conventions on Linux so probably not the best person to ask :(
@chabou
Copy link
Collaborator

@chabou chabou commented Jan 26, 2019 •
edited by juancampa

@juancampa any thought?
@doniyor2109
Copy link
Contributor

@doniyor2109 doniyor2109 commented Jan 28, 2019

@chabou How about ctrl+` ?
@juancampa
Copy link
Collaborator

@juancampa juancampa commented Feb 22, 2019 •
edited

I think it's fine to have the same hotkey on Linux, as long as it's customizable. I personally use i3wm withhout any decorations so I normally don't see/use menus. And I have removed it from Hyper as well with custom css in my ~/hyper.js
@jsrj
Copy link

@jsrj jsrj commented May 14, 2019

If it hasn't already been done, mind if I add the same functionality for Mac?
@JoffreyGe
Copy link

@JoffreyGe JoffreyGe commented Sep 2, 2019

@jsrj just a question, why do you want to add a shortcut on something ignored on Mac?
// default: true on Linux, true on Windows, ignored on macOS
If the burgerMenu can be displayed on macOS could you show me?
@AkashDhiman
Copy link

@AkashDhiman AkashDhiman commented Oct 1, 2019

Is the issue still active? Can I work on it?
@Stanzilla
Copy link
Collaborator

@Stanzilla Stanzilla commented Oct 1, 2019

Sure, go ahead :)
@gabrieldrs gabrieldrs mentioned this issue Oct 2, 2019
Open
@Amagon96
Copy link

@Amagon96 Amagon96 commented Dec 11, 2019

I didn't see a merge requesto for this issue, is still opened? 😮
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted 🎨 Type: Enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
@Stanzilla @juancampa @chabou @gwojan @JoffreyGe @doniyor2109 @jsrj @Amagon96 @AkashDhiman
You can’t perform that action at this time.