close
The Wayback Machine - https://web.archive.org/web/20200616131158/https://github.com/palantir/blueprint/issues/3919
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dividers in Control Groups have incorrect margins #3919

Open
cmslewis opened this issue Jan 13, 2020 · 2 comments
Open

Dividers in Control Groups have incorrect margins #3919

cmslewis opened this issue Jan 13, 2020 · 2 comments

Comments

@cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Jan 13, 2020

Environment

  • Package version(s): @blueprintjs/core ^3.22.3
  • Browser and OS versions: Mac OS X Chrome 79.0.3945.88

If possible, link to a minimal repro (fork this code sandbox):

Steps to reproduce

Spotted this while building a <ControlGroup> that contained buttons, selects, and some dividers.

<ControlGroup>
    // ...Other controls...
    <Button />
    <Divider />
    <Button />
    // ...Other controls...
</ControlGroup>

Actual behavior

The divider doesn't have its usual 5px padding. Instead, <ControlGroup> overrides with a default -1px padding for all controls.

Expected behavior

The divider should have a 5px padding when inside a `.

Possible solution

// Special case for dividers
.bp3-control-group .bp3-divider {
    margin: 5px;
}

Labeling P3 because it's an easy 1-line fix of custom CSS for application authors. Filing quickly for tracking, but may be able to open a PR soon.

@lidyho0708

This comment was marked as off-topic.

@lidyho0708

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.