close
The Wayback Machine - https://web.archive.org/web/20200916142827/https://github.com/Keyang/node-csvtojson/issues/358
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation example typo/bug #358

Open
stevexm opened this issue Jan 20, 2020 · 0 comments
Open

Documentation example typo/bug #358

stevexm opened this issue Jan 20, 2020 · 0 comments

Comments

@stevexm
Copy link

@stevexm stevexm commented Jan 20, 2020

Hi, minor issue in the "Add asynchronous line by line processing support" (link to example) documentation.

The feature detail example:.

csv()
.fromFile(csvFilePath)
.subscribe((json,lineNumber)=>{
        return Promise((resolve,reject)=>{
  })
},onError, onComplete)

Need to return a "new" Promise:

csv()
.fromFile(csvFilePath)
.subscribe((json,lineNumber)=>{
        return new Promise((resolve,reject)=>{
  })
},onError, onComplete)

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.