close
The Wayback Machine - https://web.archive.org/web/20200618145938/https://github.com/snipsco/snips-nlu/issues/793
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing curly brace being stripped from slot value #793

Open
Shotgun167 opened this issue May 1, 2019 · 3 comments
Open

trailing curly brace being stripped from slot value #793

Shotgun167 opened this issue May 1, 2019 · 3 comments
Labels

Comments

@Shotgun167
Copy link

@Shotgun167 Shotgun167 commented May 1, 2019

I have some values in slots that are surrounded by curly braces and are meant to be returned as is. Instead, the trailing brace is being stripped. "${website}" becomes "${website". I have training examples where the whole "${website}" is included. Is there a way to change this behavior?

@adrienball
Copy link
Contributor

@adrienball adrienball commented May 3, 2019

@Shotgun167 ,
This is indeed a limitation due to the current tokenization which strips some punctuation.
However, the "${website}" value should still be retrieved in the resolved value field:

{
  "input": "go to ${website}",
  "intent": {
    "intentName": "go_to_url",
    "probability": 1.0
  },
  "slots": [
    {
      "entity": "url",
      "range": {
        "end": 15,
        "start": 6
      },
      "rawValue": "${website",  # TRUNCATED VALUE HERE
      "slotName": "url",
      "value": {
        "kind": "Custom",
        "value": "${website}"  # FULL VALUE HERE
      }
    }
  ]
}

The plan (mid-term) is to have a tokenizer component which will be customized through the NLU configuration.

@Shotgun167
Copy link
Author

@Shotgun167 Shotgun167 commented May 3, 2019

I am working around it right now. I substitute in a crazy string for the trailing punctuating before parsing, and then swap it back out of the response. This is a nasty, ugly hack that makes code reviewers cry. So, I look forward to the customizable parser.

Is it possible to guesstimate a timeframe?
And, yes, I do have time to offer help, though I will not swear that I have the relevant expertise.

@adrienball
Copy link
Contributor

@adrienball adrienball commented May 3, 2019

It is not prioritized yet so I can't give you a good ETA, but I think this could be done within the next 3 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.