Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd regression test for #19269 #19282
Merged
Conversation
|
|
||
| Scheduler.unstable_flushAll(); | ||
| jest.runAllTimers(); | ||
| expect(submits).toBe(1); |
This comment has been minimized.
This comment has been minimized.
gaearon
Jul 8, 2020
•
Author
Member
This is the part that failed before the fix because it would double-fire.
sizebot
commented
Jul 8, 2020
codesandbox
bot
commented
Jul 8, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9dae847:
|
|
Great followup and test |
sizebot
commented
Jul 8, 2020
|
Nice one :) |
gaearon
merged commit e0e6b9c
into
facebook:master
32 checks passed
32 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant
Your tests passed on CircleCI!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gaearon commentedJul 8, 2020
Verified it breaks if #19269 is reverted.