close
The Wayback Machine - https://web.archive.org/web/20200725024358/https://github.com/facebook/react/pull/18808
Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Flight to Transport #18808

Merged
merged 2 commits into from May 3, 2020
Merged

Rename Flight to Transport #18808

merged 2 commits into from May 3, 2020

Conversation

@sebmarkbage
Copy link
Member

sebmarkbage commented May 3, 2020

Flight is still the codename for the implementation details (like Fiber).

However, now the public package is react-transport-... which is only intended to be used directly by integrators into meta-frameworks.
@sebmarkbage
Rename Flight to Transport
Loading status checks…
d20b887 
Flight is still the codename for the implementation details (like Fiber).

However, now the public package is react-transport-... which is only
intended to be used directly by integrators.
@sebmarkbage sebmarkbage requested a review from gaearon May 3, 2020
@sizebot
Copy link

sizebot commented May 3, 2020 •
edited

Details of bundled changes.

Comparing: 93e078d...914c377

react-transport-dom-webpack

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-transport-dom-webpack-server.browser.development.js n/a n/a 0 B 13.3 KB 0 B 3.7 KB UMD_DEV
react-transport-dom-webpack-server.browser.production.min.js n/a n/a 0 B 3.77 KB 0 B 1.67 KB UMD_PROD
react-transport-dom-webpack-server.browser.development.js n/a n/a 0 B 12.33 KB 0 B 3.58 KB NODE_DEV
react-transport-dom-webpack-plugin.development.js n/a n/a 0 B 685 B 0 B 407 B NODE_DEV
react-transport-dom-webpack-server.browser.production.min.js n/a n/a 0 B 3.59 KB 0 B 1.58 KB NODE_PROD
react-transport-dom-webpack-plugin.production.min.js n/a n/a 0 B 399 B 0 B 292 B NODE_PROD
react-transport-dom-webpack.development.js n/a n/a 0 B 16.89 KB 0 B 4.84 KB UMD_DEV
react-transport-dom-webpack.production.min.js n/a n/a 0 B 3.67 KB 0 B 1.7 KB UMD_PROD
react-transport-dom-webpack.development.js n/a n/a 0 B 15.73 KB 0 B 4.71 KB NODE_DEV
react-transport-dom-webpack.production.min.js n/a n/a 0 B 3.49 KB 0 B 1.61 KB NODE_PROD
react-transport-dom-webpack-server-runtime.development.js n/a n/a 0 B 3.08 KB 0 B 1.1 KB NODE_DEV
react-transport-dom-webpack-server-runtime.production.min.js n/a n/a 0 B 514 B 0 B 352 B NODE_PROD
react-transport-dom-webpack-server.node.development.js n/a n/a 0 B 13.27 KB 0 B 3.85 KB NODE_DEV
react-transport-dom-webpack-server.node.production.min.js n/a n/a 0 B 3.76 KB 0 B 1.61 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 914c377

@codesandbox
Copy link

codesandbox bot commented May 3, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 914c377:

Sandbox Source
floral-rgb-rxb2i Configuration
@sizebot
Copy link

sizebot commented May 3, 2020 •
edited

Details of bundled changes.

Comparing: 93e078d...914c377

react-transport-dom-webpack

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-transport-dom-webpack-plugin.production.min.js n/a n/a 0 B 386 B 0 B 284 B NODE_PROD
react-transport-dom-webpack-server.browser.development.js n/a n/a 0 B 12.32 KB 0 B 3.57 KB NODE_DEV
react-transport-dom-webpack-server.browser.production.min.js n/a n/a 0 B 3.57 KB 0 B 1.57 KB NODE_PROD
react-transport-dom-webpack-server-runtime.development.js n/a n/a 0 B 3.07 KB 0 B 1.09 KB NODE_DEV
react-transport-dom-webpack-server-runtime.production.min.js n/a n/a 0 B 501 B 0 B 343 B NODE_PROD
react-transport-dom-webpack-plugin.development.js n/a n/a 0 B 672 B 0 B 398 B NODE_DEV
react-transport-dom-webpack-server.node.development.js n/a n/a 0 B 13.26 KB 0 B 3.85 KB NODE_DEV
react-transport-dom-webpack-server.node.production.min.js n/a n/a 0 B 3.75 KB 0 B 1.61 KB NODE_PROD
react-transport-dom-webpack.development.js n/a n/a 0 B 16.88 KB 0 B 4.83 KB UMD_DEV
react-transport-dom-webpack.production.min.js n/a n/a 0 B 3.66 KB 0 B 1.69 KB UMD_PROD
react-transport-dom-webpack.development.js n/a n/a 0 B 15.72 KB 0 B 4.7 KB NODE_DEV
react-transport-dom-webpack-server.browser.development.js n/a n/a 0 B 13.29 KB 0 B 3.69 KB UMD_DEV
react-transport-dom-webpack.production.min.js n/a n/a 0 B 3.48 KB 0 B 1.6 KB NODE_PROD
react-transport-dom-webpack-server.browser.production.min.js n/a n/a 0 B 3.76 KB 0 B 1.66 KB UMD_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 914c377

@sebmarkbage
Rename names
Loading status checks…
914c377
@sebmarkbage
sebmarkbage reviewed May 3, 2020
View changes
scripts/rollup/bundles.js
@@ -313,7 +313,7 @@ const bundles = [
{
bundleTypes: [FB_WWW_DEV, FB_WWW_PROD],
moduleType: RENDERER,
entry: 'react-flight-dom-relay',
entry: 'react-transport-dom-relay',
global: 'ReactFlightDOMRelayClient',

This comment has been minimized.

Sign in to view
@sebmarkbage

sebmarkbage May 3, 2020

Author Member

I kept this name so we don't break the sync but we should follow up to rename this internally.
@gaearon
gaearon approved these changes May 3, 2020
View changes
@sebmarkbage sebmarkbage merged commit 64d4b84 into facebook:master May 3, 2020
31 checks passed
31 checks passed
ci/circleci: RELEASE_CHANNEL_stable_yarn_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_persistent Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: RELEASE_CHANNEL_stable_yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: sizebot_stable Your tests passed on CircleCI!
Details
ci/circleci: yarn_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_flow Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint Your tests passed on CircleCI!
Details
ci/circleci: yarn_lint_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_devtools Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_prod_www_variant Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www Your tests passed on CircleCI!
Details
ci/circleci: yarn_test_www_variant Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@sebmarkbage @sizebot @gaearon @facebook-github-bot
You can’t perform that action at this time.