close
The Wayback Machine - https://web.archive.org/web/20201023152427/https://github.com/facebook/react/issues/19219
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler dev tools suggestion: in "ranked" view, add a way to group/aggregate component instances #19219

Open
OliverJAsh opened this issue Jun 30, 2020 · 1 comment

Comments

@OliverJAsh
Copy link

@OliverJAsh OliverJAsh commented Jun 30, 2020

(Deleted template as this is a suggestion, not a bug.)

In the profiler's "ranked" view, when there are many instances of a single component, there's no way to answer the question "how much time did this component spend rendering across all instances.

For example, here I have a component called PhotoLink which is used in many places across the tree. The "ranked" view shows us that each render is very cheap, but it does not tell us the aggregate cost of this component.

Perhaps we could add something to dev tools to group/aggregate component instances?

image

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 6, 2020

Not sure how I feel about this. Marking for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.