close
The Wayback Machine - https://web.archive.org/web/20210128113323/https://github.com/php/php-src/pull/5598
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNKNOWN default values in ext/xml-rpc, ext/mbstring, and ext/gd #5598

Closed
wants to merge 2 commits into from

Conversation

@kocsismate
Copy link
Member

@kocsismate kocsismate commented May 19, 2020

No description provided.

@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch 2 times, most recently from 1888012 to f35ac99 May 19, 2020
ext/gd/gd.stub.php Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch 2 times, most recently from dacbf09 to 003aba6 May 25, 2020
@nikic
Copy link
Member

@nikic nikic commented May 25, 2020

Segfaults in CI are from d609882.

@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch from 166f047 to 75ff463 May 26, 2020
ext/gd/gd.c Show resolved Hide resolved
ext/gd/gd.c Outdated Show resolved Hide resolved
ext/gd/gd.c Show resolved Hide resolved
ext/gd/gd.c Outdated Show resolved Hide resolved
ext/mbstring/mbstring.stub.php Outdated Show resolved Hide resolved
ext/xmlrpc/xmlrpc-epi-php.c Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch 3 times, most recently from 6aa50f6 to a99f20b May 28, 2020
ext/gd/gd.c Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch from a99f20b to 2984edc May 28, 2020
ext/xmlrpc/xmlrpc-epi-php.c Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch 2 times, most recently from 0bb4b15 to 789077b May 28, 2020
@nikic
Copy link
Member

@nikic nikic commented May 28, 2020

The xmlrpc changes LGTM now, feel free to already commit those to get that unblocked.

@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch from 789077b to aa44a8e May 28, 2020
@kocsismate
Copy link
Member Author

@kocsismate kocsismate commented May 28, 2020

@cmb69 xmlrpc is good to go now :)

ext/gd/gd.c Outdated Show resolved Hide resolved
ext/gd/gd.c Outdated Show resolved Hide resolved
ext/mbstring/mbstring.c Show resolved Hide resolved
ext/mbstring/php_mbregex.c Outdated Show resolved Hide resolved
ext/mbstring/php_mbregex.c Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch 2 times, most recently from 8f44ac6 to 1cba4eb Jul 21, 2020
@kocsismate
Copy link
Member Author

@kocsismate kocsismate commented Jul 27, 2020

@cmb69 Could you please take another look at the recent changes about the image* functions?

I think the PR is fairly close to be ready for the merge, since it has been reviewed a few times before. :)

Copy link
Contributor

@cmb69 cmb69 left a comment

@cmb69 Could you please take another look at the recent changes about the image* functions?

Thanks! Looks pretty good to me, but maybe have an eye on the two minor issues mentioned below.

ext/gd/gd.c Outdated Show resolved Hide resolved
ext/gd/gd.c Show resolved Hide resolved
ext/gd/gd.c Show resolved Hide resolved
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch from 1cba4eb to 697bb2a Jul 28, 2020
@kocsismate kocsismate force-pushed the kocsismate:nullable-default4 branch from 697bb2a to 658cc94 Jul 28, 2020
@nikic
nikic approved these changes Jul 28, 2020
@php-pulls php-pulls closed this in ac0da09 Jul 28, 2020
@kocsismate kocsismate deleted the kocsismate:nullable-default4 branch Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants