close
The Wayback Machine - https://web.archive.org/web/20201225000401/https://github.com/reactjs/reactjs.org/pull/3218
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong highlighted line numbers in nested Profiler example #3218

Merged
merged 1 commit into from Sep 29, 2020

Conversation

@dtinth
Copy link
Contributor

@dtinth dtinth commented Aug 20, 2020

Before: The Profiler component is not highlighted.

image

After:

No more deploy previews? 🥺

@lex111
lex111 approved these changes Sep 29, 2020
Copy link
Member

@lex111 lex111 left a comment

Seems legit.

@lex111 lex111 merged commit eaa502f into reactjs:master Sep 29, 2020
2 checks passed
2 checks passed
Facebook CLA Check Contributor License Agreement is valid!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@lex111
Copy link
Member

@lex111 lex111 commented Sep 29, 2020

@dtinth thanks!

@reactjs-bot
Copy link

@reactjs-bot reactjs-bot commented Oct 15, 2020

Deploy preview for reactjs ready!

Built with commit 06d6e51

https://deploy-preview-3218--reactjs.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.