close
The Wayback Machine - https://web.archive.org/web/20200831022137/https://github.com/ornicar/lila/issues/6939
Skip to content

/ lila

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noImplicitAny for ui/analysis, ui/puzzle, ui/round #6939

Open
niklasf opened this issue Jul 5, 2020 · 2 comments
Open

noImplicitAny for ui/analysis, ui/puzzle, ui/round #6939

niklasf opened this issue Jul 5, 2020 · 2 comments
Labels
chore good first issue no scala

Comments

@niklasf
Copy link
Collaborator

@niklasf niklasf commented Jul 5, 2020 •
edited

noImplicitAny will help with some refactorings (such as ornicar/chessground#145). Even partial progress is useful.

  1. Pick one of:

    • ui/analyse
    • ui/puzzle
    • ui/round

  2. Temporarily set noImplicitAny to true in ui/.../tsconfig.json.

  3. To compile use yarn run dev, yarn run dev --watch or yarn run tsc --noEmit in ui/.... Fix some issues. (Usually it is better to leave issues unsolved than making any explicit).

  4. Turn noImplicitAny back off, unless no issues remain.
@niklasf niklasf changed the title noImplicitAny for ui/puzzle noImplicitAny for ui/analysis, ui/puzzle, ui/round Jul 5, 2020
greg-finley added a commit to greg-finley/lila that referenced this issue Jul 6, 2020
@greg-finley
Types for ui/puzzle, for ornicar#6939
Loading status checks…
fe2eb66
ornicar added a commit that referenced this issue Jul 6, 2020
@ornicar
Merge pull request #6941 from greg-finley/uipuzzle
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0510222 
Types for ui/puzzle, for #6939
@niklasf niklasf mentioned this issue Jul 7, 2020
Merged
9 of 9 tasks complete
@abhigyank
Copy link

@abhigyank abhigyank commented Jul 8, 2020

Is ui/puzzle complete by #6941? Can we tick it in the description if it is so :)
@greg-finley
Copy link
Contributor

@greg-finley greg-finley commented Jul 8, 2020

Nope, there were still a few I wasn’t able to add types for.
niklasf added a commit that referenced this issue Jul 11, 2020
@niklasf
finish noImplicitAny for ui/puzzle (#6939)
Loading status checks…
8af0371
greg-finley added a commit to greg-finley/lila that referenced this issue Jul 11, 2020
@greg-finley
Types for ui/round for ornicar#6939
Loading status checks…
4d8a1e5
ornicar added a commit that referenced this issue Jul 15, 2020
@ornicar
Merge pull request #6974 from greg-finley/uiround2
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b428035 
Types for ui/round for #6939
ornicar added a commit that referenced this issue Jul 15, 2020
@ornicar
Merge branch 'master' of github.com:ornicar/lila
Loading status checks…
430f1bf 
* 'master' of github.com:ornicar/lila:
  Remove k? thing
  optimize PairingRepo.lastOpponents (#6988)
  Hide the scrollbar on the lobby graph
  Types for ui/round for #6939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue no scala
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@niklasf @abhigyank @greg-finley
You can’t perform that action at this time.