Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix the UX of thread composer to prevent accidental community/channel posts #2872
Comments
|
I think a quick win here would be:
|
|
Hi If allowed I would like to take this up as my first issue. I am assuming the thread composer is the New Conversion UI wherein "To:" field will remain empty and near Publish button down at bottom we will have two new selects for community and channel right? Sorry for my usage of non-technical terms but I am trying to relate components to UI. Any guidance/help would be great. |
|
Yep that's it @bishwenduk029! |
we don't need to show "To:" also, put some title like "New Conversation" what do you say @mxstbr If you need any help, i can (though i also new) |
|
Yep! This will also affect some layout stuff on mobile, but we'll probably want to at least match behavior where the community/channel selection requires the user to make the decision before hitting publish :) |
|
Great then, thanks @mxstbr, @dev-drprasad and @brianlovin, I will start working on this and come up with a solution ASAP |
|
Hey @dev-drprasad I was working on this issue. I was able to make changes, but the onChange event is not firing on select....have you come across such an issue before ? RequiredSelector in ComposerWithData....I tried but was unable to post this question on Spectrum.Chat so posting here .... |
|
@bishwenduk029 since we are moving |
|
In local/dev env I think there is some issue with select, onChange event is not being fired even with alpha branch code. Has anyone faced a similar problem, or am i doing something wrong ? Should I create a pull request for review? I have completed the changes but unable to test them because of select... |
|
@bishwenduk029 please send PR, so that I can take a look |
|
@bishwenduk029 if you have only spectrum community in you local development, you can't trigger |
|
Oh I see, sure thing I will try that thnx @dev-drprasad . |
|
Hi @dev-drprasad I have created a pull request for the preliminary changes and was hoping if you could review it and let me know if I am going in the right path, meanwhile I will look perform some analysis to find if any component may need change, also I think I have to modify the cypress scripts. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

The thread composer today makes it ridiculously easy to accidentally post in the wrong community or channel; we need to make this way more clear or make community/channel selection a discrete step in the thread publishing flow.