close
The Wayback Machine - https://web.archive.org/web/20200918211311/https://github.com/withspectrum/spectrum/issues/2872
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the UX of thread composer to prevent accidental community/channel posts #2872

Open
brianlovin opened this issue Apr 15, 2018 · 13 comments
Open

Comments

@brianlovin
Copy link
Member

@brianlovin brianlovin commented Apr 15, 2018

The thread composer today makes it ridiculously easy to accidentally post in the wrong community or channel; we need to make this way more clear or make community/channel selection a discrete step in the thread publishing flow.

@spectrum-bot spectrum-bot bot added the Feature label Apr 15, 2018
@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Apr 16, 2018

I think a quick win here would be:

  • Don't select any community or channel by default, leave those empty and grey out the publish button until both are selected
  • Move the selects down next to the publish button
  • Only on the community view and channel views select a community and channel by default
@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 17, 2018

Hi If allowed I would like to take this up as my first issue. I am assuming the thread composer is the New Conversion UI wherein "To:" field will remain empty and near Publish button down at bottom we will have two new selects for community and channel right? Sorry for my usage of non-technical terms but I am trying to relate components to UI. Any guidance/help would be great.

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Apr 17, 2018

Yep that's it @bishwenduk029!

@dev-drprasad
Copy link
Contributor

@dev-drprasad dev-drprasad commented Apr 17, 2018

@bishwenduk029

I am assuming the thread composer is the New Conversion UI wherein "To:" field will remain empty

we don't need to show "To:" also, put some title like "New Conversation" what do you say @mxstbr

If you need any help, i can (though i also new)

@brianlovin
Copy link
Member Author

@brianlovin brianlovin commented Apr 17, 2018

Yep! This will also affect some layout stuff on mobile, but we'll probably want to at least match behavior where the community/channel selection requires the user to make the decision before hitting publish :)

@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 18, 2018

Great then, thanks @mxstbr, @dev-drprasad and @brianlovin, I will start working on this and come up with a solution ASAP

@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 20, 2018

Hey @dev-drprasad I was working on this issue. I was able to make changes, but the onChange event is not firing on select....have you come across such an issue before ? RequiredSelector in ComposerWithData....I tried but was unable to post this question on Spectrum.Chat so posting here ....

@dev-drprasad
Copy link
Contributor

@dev-drprasad dev-drprasad commented Apr 20, 2018

@bishwenduk029 since we are moving RequiredSelector to other position in same component onChange should work. can you check browser console for any errors ??

@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 21, 2018

In local/dev env I think there is some issue with select, onChange event is not being fired even with alpha branch code. Has anyone faced a similar problem, or am i doing something wrong ? Should I create a pull request for review? I have completed the changes but unable to test them because of select...

@dev-drprasad
Copy link
Contributor

@dev-drprasad dev-drprasad commented Apr 21, 2018

@bishwenduk029 please send PR, so that I can take a look

@dev-drprasad
Copy link
Contributor

@dev-drprasad dev-drprasad commented Apr 21, 2018

@bishwenduk029 if you have only spectrum community in you local development, you can't trigger onChange because there is no other community to change. try creating one more community in local development. same goes for channels also

@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 21, 2018

Oh I see, sure thing I will try that thnx @dev-drprasad .

@bishwenduk029
Copy link

@bishwenduk029 bishwenduk029 commented Apr 21, 2018

Hi @dev-drprasad I have created a pull request for the preliminary changes and was hoping if you could review it and let me know if I am going in the right path, meanwhile I will look perform some analysis to find if any component may need change, also I think I have to modify the cypress scripts.

#2936

@bishwenduk029 bishwenduk029 mentioned this issue Apr 22, 2018
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.