close
The Wayback Machine - https://web.archive.org/web/20200918211109/https://github.com/withspectrum/spectrum/issues/3071
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll on composer overlay when creating a new thread #3071

Open
johnnynotsolucky opened this issue May 11, 2018 · 15 comments
Open

Cannot scroll on composer overlay when creating a new thread #3071

johnnynotsolucky opened this issue May 11, 2018 · 15 comments

Comments

@johnnynotsolucky
Copy link
Contributor

@johnnynotsolucky johnnynotsolucky commented May 11, 2018

Reported here: https://spectrum.chat/?t=3a8e24ab-972f-496b-946a-2812ebd7c94b

Hey friends. If I have the "new conversation" modal open on my macbook 15", and I scroll down so the modal isn't visible anymore, then I can't scroll up anymore and get it back.

I thought it might be an easy fix, #3070, but I was wrong 😕

@spectrum-bot spectrum-bot bot added the Bug label May 11, 2018
@brianlovin
Copy link
Member

@brianlovin brianlovin commented May 15, 2018

@johnnynotsolucky I think the optimal fix here is to refactor so that we only have one composer component. Right now we have two - the first is what you see if you compose a thread from the inbox, the second is what you see when composing from a community/channel profile view.

What might work is if we had the composer inside a 'slideout' component, similar to threads - that way it could be toggled from anywhere and would appear on top of whatever context you're in. What do you think?

@johnnynotsolucky
Copy link
Contributor Author

@johnnynotsolucky johnnynotsolucky commented May 18, 2018

Yeah I agree, I really like the slideout idea. It would also be nice to have the same composing experience from the inbox and profile view 🙂

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Dec 15, 2018

you could remove the overlay temporarily, so you have normal scroll behaviour
image 2018-12-15 at 4 14 16 pm

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 7, 2019

I've noticed a couple of issues concerning the composer design etc. @brianlovin this is an example of what a slide out composer could look like

composergif

@brianlovin
Copy link
Member

@brianlovin brianlovin commented Jan 8, 2019

@ThomasRoest I would love to move to this slideout composer, and ideally combine it with the dashboard thread composer as well (right now it's 2 components - tech debt). Your mock feels so much better - do you think it's feasible to combine?

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 9, 2019

I'm not sure yet ( considering the amount of work etc, differences.) But I'll look into it!

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 15, 2019

What's possible is adding the same composer from the community to the dashboard like this:

screen recording 2019-01-15 at 03 40 pm

@brianlovin
Copy link
Member

@brianlovin brianlovin commented Jan 15, 2019

This doesn't seem too bad (although we should attempt to stretch the contents of the composer so that the channel selection and publish button are at the bottom of the page and don't get pushed off if the thread becomes long.

Wdyt @superbryntendo ?

@superbryntendo
Copy link
Contributor

@superbryntendo superbryntendo commented Jan 15, 2019

totally agree. i would love to have the buttons pinned top or bottom and have the text area scroll.

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 16, 2019

in /components/rich-text-editor/container.js should I use the editor with version 2 prop?

if (version === 2) {

@superbryntendo
Copy link
Contributor

@superbryntendo superbryntendo commented Jan 16, 2019

if we're moving all of them to one component, we shouldn't need that prop anymore. iirc I used that to handle the switch to DraftJS.

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 16, 2019

ok, and what code block is more recent / should be leading? first or second?
There are some differences including the way users embed or upload photos ( see screenshots )

image 2019-01-17 at 9 12 29 am

and

image 2019-01-17 at 9 13 34 am

@ThomasRoest
Copy link
Contributor

@ThomasRoest ThomasRoest commented Jan 19, 2019

there are a few issues left to fix, but this is the current status @brianlovin

newcomposer

@superbryntendo
Copy link
Contributor

@superbryntendo superbryntendo commented Jan 22, 2019

The first one (with the inserter) is the correct one.

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jan 23, 2019

Amazing @ThomasRoest! Want to submit a first PR and then continue iterating? That would help me figure out if I will block you with #4564

@ThomasRoest ThomasRoest mentioned this issue Jan 24, 2019
5 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.