close
The Wayback Machine - https://web.archive.org/web/20200831160446/https://github.com/denoland/deno/issues/6685
Skip to content

/ deno

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--allow-net=:8080 broken #6685

Open
brandonkal opened this issue Jul 8, 2020 · 5 comments
Open

--allow-net=:8080 broken #6685

brandonkal opened this issue Jul 8, 2020 · 5 comments
Labels
bug cli good first issue

Comments

@brandonkal
Copy link
Contributor

@brandonkal brandonkal commented Jul 8, 2020

If any code uses shorthand notation:

import { serve } from "https://deno.land/std/http/server.ts"
const PORT = 8080
serve(`:${PORT}`)

then any variant of

deno run --allow-net=:8080 server.ts
deno run --allow-net=localhost:8080 server.ts
deno run --allow-net=0.0.0.0:8080 server.ts
deno run --allow-net=127.0.0.1:8080 server.ts

fails.

Unfortunately, a lot of libraries in x use this pattern which makes locking down permissions impossible without forking all those libraries.
@ry ry added bug cli labels Jul 8, 2020
@ry
Copy link
Member

@ry ry commented Jul 8, 2020

Maybe this was introduced in 74c2605 ?

I think this shouldn't be a terrible difficult or involved fix. I will mark as "Good First Issue".
@ry ry added the good first issue label Jul 8, 2020
@KrisChambers
Copy link
Contributor

@KrisChambers KrisChambers commented Jul 9, 2020

I would like to take a stab at this one.
@jacobgc
Copy link
Contributor

@jacobgc jacobgc commented Jul 9, 2020

Just tested this with deno version 1.1.2 which is before my commit (74c2605) and can confirm that this issue is still present.
KrisChambers added a commit to KrisChambers/deno that referenced this issue Jul 10, 2020
@KrisChambers
Fix issue denoland#6685: hostname not being set to default 0.0.0.0
2c99aa5
KrisChambers added a commit to KrisChambers/deno that referenced this issue Jul 10, 2020
@KrisChambers
Fix issue denoland#6685: hostname not being set to default 0.0.0.0
e96e47d
ry pushed a commit that referenced this issue Jul 11, 2020
@KrisChambers
Fix for issue #6685: --allow-net=:8080 broken (#6698)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d01eb6d
@utkzas
Copy link

@utkzas utkzas commented Jul 14, 2020 •
edited

I also want to contribute to this project (denojs). Can someone tell me how should I start?
@jsouto18
Copy link
Contributor

@jsouto18 jsouto18 commented Jul 20, 2020

I've tested this on the latest release and I've managed to execute the code successfully running deno run --allow-net=:8080 server.ts or deno run --allow-net=0.0.0.0:8080 server.ts which seems to be the intended behaviour as the serve function binds to 0.0.0.0:8080.
@ry is this the intended behaviour?
The only other thing I found odd was trying to run serve(127.0.0.1:8080) and running deno run --allow-net=localhost:8080 server.ts fails because localhost is not resolved to the configured IP, for example in /etc/hosts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cli good first issue
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@ry @jacobgc @KrisChambers @brandonkal @jsouto18 @utkzas
You can’t perform that action at this time.