close
The Wayback Machine - https://web.archive.org/web/20201230233204/https://github.com/bombomby/optick/issues/50
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thread Filter to the Timeline #50

Open
bombomby opened this issue Jan 21, 2019 · 3 comments
Open

Add Thread Filter to the Timeline #50

bombomby opened this issue Jan 21, 2019 · 3 comments
Assignees
Milestone

Comments

@bombomby
Copy link
Owner

@bombomby bombomby commented Jan 21, 2019

Add a filter to select a subset of threads.
Use SearchBox control with DelayedTextChanged event.
Hide all of the threads on the Timeline not containing specified string (should be case-insensitive).
Use space next to the Header row on the Timelne for the search box.

Code in: ThreadView.xaml.cs

@bombomby bombomby added this to the v2.0 milestone Jan 21, 2019
@bombomby bombomby self-assigned this Jan 21, 2019
@bombomby
Copy link
Owner Author

@bombomby bombomby commented Jan 30, 2019

Standard WPF implementation of canvas is too slow. ThreadView control uses custom DirectX implementation to be able to handle large huge number of blocks. Code for generating threads is in function InitThreadList. Rebuilding Meshes is quite expensive operation, so please keep all the meshes generated, just set 'visibility' to false for filtered out threads and keep mesh generated.

@bombomby bombomby assigned samsonovsa and unassigned bombomby Jan 31, 2019
@bombomby
Copy link
Owner Author

@bombomby bombomby commented Feb 14, 2019

image

@bombomby
Copy link
Owner Author

@bombomby bombomby commented Feb 14, 2019

Search behaviour:

  1. case-insensitive
  2. if search box contains multiple words separated by space - it should search for all the threads containing any of the word (one is enough)
@bombomby bombomby assigned bombomby and unassigned samsonovsa Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.