Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upoverlays: collect PVCs into a separate base #815
Merged
Conversation
|
Wouldn't this be a problem anyway because we specify the PVC in the volume definition of the Deployment? We might need to do something like kubernetes-sigs/kustomize#2037 |
|
it assumes the overlay the customer uses also replaces/edits the mention in the deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
uwedeportivo commentedAug 7, 2020
•
edited
collects PVC resources into a separate base. this allows kustomizations to pick and choose which PVCs they want or avoid creating them altogether. we have customers that need this because they explicitly create PVs and map them to deployments/statefulsets with named claim refs.
(kustomize does not allow deletes)