close
The Wayback Machine - https://web.archive.org/web/20200918104837/https://github.com/discourse/docker_manager/pull/75
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Linting fixes #75

Open
wants to merge 4 commits into
base: master
from
Open

DEV: Linting fixes #75

wants to merge 4 commits into from

Conversation

@CvX
Copy link
Contributor

CvX commented Jul 23, 2020

Empty block statement, Don't use observers, Do not use volatile computed properties.

Not tested in any way yet. 😐 What's the recommended flow for trying out changes to docker_manager?

@eviltrout
Copy link
Member

eviltrout commented Jul 23, 2020

You should be able to run it locally - the README explains how to do it:

https://github.com/discourse/docker_manager#the-client-app

@eviltrout
Copy link
Member

eviltrout commented Jul 23, 2020

@CvX can you update this PR once you've confirmed it works locally?

@CvX
Copy link
Contributor Author

CvX commented Jul 23, 2020

omg, there's no facepalm emoji big enough for me 🤦 I must have mixed up plugins directories when looking this up, because there readme was empty and there were no frontend tests 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.