close
The Wayback Machine - https://web.archive.org/web/20210210092140/https://github.com/github/gitignore/pull/3523
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global/macOS] Prevent corruption of "Icon\r" rule #3523

Open
wants to merge 1 commit into
base: master
from

Conversation

@i-to-r
Copy link

@i-to-r i-to-r commented Sep 16, 2020

Fixed #2203 PR.

Reasons for making this change:

Make Icon\r pattern less vulnerable to editors and to auto CRLFLF conversion on commit. As @spencermathews wrote in #2337 :

Since this ignore rule may be vulnerable to editors that automatically standardize line endings, it seems imperative that updates to this file be done with care or else this rollercoaster seems likely to continue.

Note: the Start..End comment has been added because most editors display Icon[␍] pattern in two lines:

# Start of Icon[\r] pattern
Icon[
]
# End of Icon[\r] pattern

Links to documentation supporting these rule changes:

@53jk1
53jk1 approved these changes Oct 23, 2020
i-to-r added a commit to i-to-r/gitignore that referenced this pull request Oct 24, 2020
Online editor (GitHub, CodeMirror editor) test.
github#3523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants