Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove DCE and inliner #221
Merged
Conversation
The previous implementation would fail to optimize many case expressions, because the liveness information from one branch would get propagated into the other branch. Also, names of top-level decls used in module binders are allowed to appear in those sub-blocks, which has invalidated some more optimization opportunities.
The previous approach was quite eager to overestimate the number of uses of each binder, because we tend to aggressively reuse names in incomparable scopes. This patch adds an extra slot in each binder, which can be filled in with inlining hints. The whole procedure is very similar to DCE and the approach is heavily inspired by the "Secrets of the GHC inliner" paper.
apaszke
merged commit 5d38784
into
google-research:main
2 checks passed
2 checks passed
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Track liveness more accurately in DCE
The previous implementation would fail to optimize many case
expressions, because the liveness information from one branch would get
propagated into the other branch. Also, names of top-level decls used in
module binders are allowed to appear in those sub-blocks, which has
invalidated some more optimization opportunities.
Make the inliner use aggregation more accurate
The previous approach was quite eager to overestimate the number of uses
of each binder, because we tend to aggressively reuse names in
incomparable scopes. This patch adds an extra slot in each binder, which
can be filled in with inlining hints. The whole procedure is very
similar to DCE and the approach is heavily inspired by the "Secrets of
the GHC inliner" paper.