Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update references to the CLI #23052
Update references to the CLI #23052
Conversation
|
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@hramos - heads up, I need to fix remaining test failures before this ships. I will let you know when it's ready. |
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@facebook-github-bot shipit |
|
I will not rubber stamp and land your change for you @grabbou! I can import it for you and you can get your change reviewed by someone though :) |
|
@hramos I am triggering the import again - the issues seem to be fixed and failures are similar to what we have on master. Hopefully it works for you locally. |
|
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: This updates React Native to use latest CLI. We also create Metro configuration, because CLI looks for React Native in "node_modules" by default. Since we are running React Native from source, it will fail to find required files. To avoid hacky logic to detect if we are running from source backed into the CLI, I decided to leverage the Metro configuration instead. Pull Request resolved: facebook#23052 Reviewed By: rickhanlonii Differential Revision: D13719938 Pulled By: cpojer fbshipit-source-id: 1f40a40b3cdbb07ccd42daf75feb457556d3e40f
This updates React Native to use latest CLI. We also create Metro configuration, because CLI looks for React Native in "node_modules" by default. Since we are running React Native from source, it will fail to find required files.
To avoid hacky logic to detect if we are running from source backed into the CLI, I decided to leverage the Metro configuration instead.