Preact: Keep the story state between rerenders #12221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
|
Perhaps @BartWaardenburg can speak to the original change in dfce65d#diff-1c5b1f58ac17d3362f80cffd129bf688R23 |
Sorry, I can't remember wat was the reason for the change. |
|
Hi all! The original fix from @BartWaardenburg was for Preact 8. Preact 10 was a rewrite and there is no longer any reason to do the clearing between renders - if anything, clearing between renders is more likely to produce strange results than not doing so. |
developit
approved these changes
Sep 16, 2020
|
Ok. Sounds like there's a consensus that this change is a good idea. How do we proceed to get it merged? |
tmeasday
approved these changes
Sep 17, 2020
|
I'm happy to merge it, not sure what happened to the CI build though, let me see.. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Issue: #12177
What I did
With these changes, a Preact story will keep its state in between the rerenders, e.g. due to knob/control change. This will make Preact function similar to React.
How to test
TODO
TODO
No: the
forceRenderis a normal Storybook mode and thus no new functionality has been enabled in this PR.If your answer is yes to any of these, please make sure to include it in your PR.