close
The Wayback Machine - https://web.archive.org/web/20201004034933/https://github.com/kyleneideck/BackgroundMusic/issues/203
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preference for time to wait before resuming playback #203

Open
samwalshnz opened this issue Apr 6, 2019 · 1 comment
Open

Preference for time to wait before resuming playback #203

samwalshnz opened this issue Apr 6, 2019 · 1 comment

Comments

@samwalshnz
Copy link

@samwalshnz samwalshnz commented Apr 6, 2019

User story:
I'm watching a YouTube video. The person speaking in the video pauses for a moment before sentences. The pauses are long enough to be considered as 'silent' to BackgroundMusic and therefore the music plays, but then the person speaking in the video continues speaking, triggering the music playback to stop. Note: there's also a delay between the moment the person starts speaking and when the music stops, resulting in missing some of what they are saying because I can't hear them over the music.

Possible solution
Add ability (in preferences) to increase/decrease the time to wait between the moment detected sound has gone silent/stopped and when music playback should resume.

@blaues0cke
Copy link

@blaues0cke blaues0cke commented Aug 5, 2020

Vote for this. This is should basically a configuration for:

static UInt64 const kPauseDelayNSec = 1500 * NSEC_PER_MSEC;

and

static UInt64 const kMaxUnpauseDelayNSec = 3500 * NSEC_PER_MSEC;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.