close
The Wayback Machine - https://web.archive.org/web/20201125023521/https://github.com/square/leakcanary/pull/1585
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic setup when using separate LeakCanary process #1585

Merged
merged 1 commit into from Sep 14, 2019
Merged

Conversation

@pyricau
Copy link
Member

@pyricau pyricau commented Sep 14, 2019

Fixes #1584

@@ -145,6 +146,10 @@ object LeakCanary {
*/
@Volatile
var config: Config = if (AppWatcher.isInstalled) Config() else InternalLeakCanary.noInstallConfig
set(value) {
field = value
SharkLog.d { "Updated LeakCanary.config to ${AppWatcher.config} " }

This comment has been minimized.

@Armaxis

Armaxis Sep 14, 2019
Member

Nit: $value should work too?

This comment has been minimized.

@pyricau

pyricau Sep 14, 2019
Author Member

Not to mention that the code is actually wrong here

@pyricau pyricau force-pushed the py/process_clean branch from 4ba0f4d to 696d320 Sep 14, 2019
@pyricau pyricau force-pushed the py/process_clean branch from 696d320 to e827fec Sep 14, 2019
@pyricau pyricau merged commit 9810e66 into master Sep 14, 2019
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.