Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up🎃 Convert Service Classes to Static Fields 🎃 #5555
Comments
|
@calebcartwright I would like to contribute to this. Should I wait for hacktoberfest to start? |
|
Hi @calebcartwright I would love to work on some classes.I have posted the same message in discord with username cosmos |
Great! Please specify which of the service classes families you're going to work on so that we can prevent any duplicative efforts
that's up to you! We'll happily accept help with this effort regardless of what month it is, but PRs submitted before Hacktoberfest begins will obviously not count towards your Hacktoberfest contributions
Great! I've updated the above list to reflect the ones you've claimed |
|
@calebcartwright Thanks I will contribute before hacktoberfest too. I will be working on. |
|
@calebcartwright can i work on this jira jitpack jsdelivr keybase , if no one else is working on those? |
|
@calebcartwright I have finish #5555 (comment). I would like to take another modules i.e |
|
@calebcartwright I have completed #5555 (comment). Assign me If anyone hasn't started working on it.Thanks |
|
@calebcartwright Assign Me |
|
I am working on these services [nuget nycrc opencollective opm] |
|
@calebcartwright I would like to take up: Thanks :) |
|
@calebcartwright can i help out with these?
|
|
Hey @calebcartwright if no one taken |
|
@RDIL feel free to pick any 4 - 5 services which are not done and post them here or at shields discord channel to prevent duplicate work.Thanks ! |
|
@calebcartwright I am taking these files next [ powershellgallery pub puppetforge pypi ]. |
|
@calebcartwright I have changes for the above services also.Meanwhile I am working on these services [readthedocs reddit redmine repology] and open PR once the previous changes get's accepted. Thanks ! |
|
I am working on these too [ requires EDIT: @calebcartwright looks like there is nothing to work in resharper and scoop services. Please mark them as completed. I am working on [security-headers, shippable] services |
We recently completed the upgrade to Node 12 in our production environment which, among other benefits, now allows us to leverage static fields for defining core attributes like the category and route.
We've completed the refactoring of several service classes to use static fields, but there's a lot of them remaining and we could use your help to convert the rest!
What are the steps required?
This work involves updating the members in a service class (found in the *-service.js files) to convert the static getters to static fields,
For example:
becomes
If a service class doesn't have any getters (e.g. redirector classes like this one, then there's nothing needed for that class!
Additional information and references can be found in the corresponding section of the tutorial documentation as well previous PRs that did this conversion like #5552 or #5530
How to contribute?
Below is the list of remaining service class families (as a link to their location in source) that need to be refactored. If you're interested in working on this, leave a comment on this thread or drop us a note in Discord letting us know which one(s) you'd like to work on. Items that have been checked off have already been completed, but the others are up for grabs!
As a rule of thumb, we'd generally prefer to see PRs contain between 2-4 refactored service class families to keep the review and merge process streamlined. You can work on as many as you'd like, but please try to follow that guidance when contributing and split PRs accordingly!