Update packaging configuration in setup.py and MANIFEST.in #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the PR with a better title and description of your problem? I can't evaluate the change without knowing why it is required |
brettstack
reviewed
Apr 19, 2018
Do we still need the json entries in MANIFEST now?
|
@brettstack Not according to https://docs.python.org/2/distutils/sourcedist.html. Files declared in |
sanathkr
reviewed
Apr 20, 2018
LGTM
|
Can you remove the lines in MANIFEST if they're redundant. |
|
my 2c: For simplicity I would prefer not to have |
digioak-zz
changed the title
|
See https://gist.github.com/digioak/b80e3e205c35097667d42ccfcfdb8433 for packaging output |
sanathkr
reviewed
Apr 25, 2018
… available on installation
brettstack
approved these changes
Apr 25, 2018
jfuss
approved these changes
Apr 25, 2018
sanathkr
added a commit
that referenced
this issue
Apr 25, 2018
* Add new AWSSecretsManagerRotationPolicy PolicyTemplate with docs update (#361) * Update links to Policy Templates for documentation (#355) These links were broken in the documentation at https://awslabs.github.io/serverless-application-model/policy_templates.html That's because they were relative links that didn't exist within the documentation website. * OLD (Doesn't exist): https://awslabs.github.io/serverless-application-model/policy_templates_data/policy_templates.json * NEW: https://github.com/awslabs/serverless-application-model/blob/develop/docs/policy_templates_data/policy_templates.json There might be a more generic way to do this across all the documentation, but I don't know enough about Sphinx to do it generically. * Modernize Python 2 code to get ready for Python 3 (#365) Using six.string_types instead of basestring * docs: update SimpleTable example to include Properties (#374) * docs: add validation on make setup target (#375) * Added validation to the setup target and raise a clear error when pyenv is not found on your system * Remove the install target and improved the configuration validation * Updated the developer guide with a note on the pyenv requirement. * Fix the hyperlink used a markdown syntax instead of restructuredtext * Fix the note block used a markdown syntax instead of restructuredtext * Restored removed line * Correct the text a bit so that it looks ok on GitHub * Keep the pyenv word linked to the github repo * Added a way to run a single class to test * Update the branch to develop * Removed some Mac OS X code what was needed due to incorrectly installation of python * Improved the Makefile by adding a help function and added info context (mostly copied from https://github.com/aws-samples/cookiecutter-aws-sam-python) * Removed the clean target as requested in the PR * release: update setup.py (#381) * release: 1.5.1 (#391) * docs: fix "asynchronously" typo in safe_lambda_deployments.rst (#385) * docs: add Travis and PyPi badges to README (#392) * docs: update requirements paths in development guide (#396) * Update packaging configuration in setup.py and MANIFEST.in (#394) * fix: remove redundant macro resolver logic in parser to prevent plugins from running twice (#398)
keetonian
pushed a commit
to keetonian/serverless-application-model
that referenced
this issue
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description of changes:
Refactoring packaging configuration, removing
package_datainsetup.pyand adding JSON files to MANIFEST.inBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
The text was updated successfully, but these errors were encountered: