Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTests TODO #92
Tests TODO #92
Comments
|
Can I try adding tests for bot-detector? |
|
@aneeshrelan yup, will create a separate issue for that now |
|
@aneeshrelan check #111 |
|
@talentlessguy I see some tests for the mentioned wares, are they still needed? |
|
I can take up some tests |
|
@shubhi23994 which tests would you like to take up? I will create a separate issue for those you pick |
|
@aneeshrelan I receive lots of PRs during hacktoberfest so I could have missed some of them and yes, tests are still needed |
|
I can pick up jsonp to start with |
|
@shubhi23994 alright, making a new issue then :D |
|
@shubhi23994 write in #123 so i can assign you |
|
Hi, may I take pick ETag? |
|
@MaurizioPz yup, pls wait a sec imma setting up a new issue for this (to later assign it to you) |
|
@MaurizioPz check this: #133 |
|
Hi, may I take also req |
|
@MaurizioPz alright, making a new issue |
|
@MaurizioPz check #140 and write there pls so I can assign you |
|
Hey, @talentlessguy! I'm not familiar with the codebase, but I'm happy to try writing some tests if you still need it! |
|
@alcar hi! you can pick any of the things to test, and I'll open a separate issue for you - e.g. if you decide to test pick the one you want and I'll assign you to those tests |
|
Do you have any recommendations for a newcomer? If not, I can just pick up the first available one from the list! |
|
@alcar but feel free to pick anything else |
|
@talentlessguy Sounds great! Could you please create an issue and assign it to me then? |
|
@alcar yup currently making an issue for you |


The final goal is of this issue is to achieve ~80-100% coverage
here's a todo list of things that require tests (based on the
__tests__folder):app-app.set,app.enable,app.disable(codecov)onError- Test a case where an error doesn't have an HTTP status code, neither is a string (codecov)res.format- ifdefaultonly is specified, call it as a function (codecov)res.format- if nothing is specified, throw 406 (codecov)Cookie- cookie is serialized properly.pugfiles torenderFileof thepugmoduleIf you want to help with tests, write down to this thread with your questions