close
The Wayback Machine - https://web.archive.org/web/20201203030440/https://github.com/kognise/water.css/issues/31
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for <meter>, <progress> #31

Open
rahuldottech opened this issue Apr 8, 2019 · 7 comments
Open

Support for <meter>, <progress> #31

rahuldottech opened this issue Apr 8, 2019 · 7 comments

Comments

@rahuldottech
Copy link

@rahuldottech rahuldottech commented Apr 8, 2019

HTML supports built-in progress bars:

<meter value="4" min="0" max="5">Section 4 of 5</meter><br>
<progress value="69" max="420"></progress>
<meter value="0.69">69%</meter>

Support for this stuff too would be cool :)

@kylejrp
Copy link
Collaborator

@kylejrp kylejrp commented Apr 11, 2019

MDN has good documentation for the <meter> and <progress> elements.

There's a :indeterminate pseudo class we'd want to style here as well.

CSS Tricks has a good article called HTML5 Progress Element on how you can style these, but it seems like a slippery slope of vendor prefixes to get this styling working consistently across browsers.

CSS Tricks also has an article on the HTML5 Meter Element, but it's a similar story of vendor prefixes.

This seems super worthwhile though - these elements are easy to create in HTML, they're just difficult to style.

@kylejrp
Copy link
Collaborator

@kylejrp kylejrp commented May 4, 2019

We'd love to have someone contribute to this issue! This work could probably be split up into the <meter> and <progress> elements, but it's also okay if you want to take on both at the same time.

To contribute, we'd be looking for you to add a new .scss file in /src/parts/. You'll want to reuse any variables from src/dark.scss or src/light.scss if they make sense, or create and reference new variables if necessary.

There's lots of creative freedom with this issue. Feel free to try something unique, as long as it fits in with the general aesthetic of water.css! I think at minimum we'd be looking for the same rounded corners and similar colors that the themes already use.

Let us know if you need any help or if you have any questions about how to contribute!

@asoback
Copy link
Contributor

@asoback asoback commented May 24, 2019

I'd like to try to come up with something for the progress bar at least. Thank you for all the resources!

@asoback
Copy link
Contributor

@asoback asoback commented Jun 10, 2019

Hey, I wasn't able to get animations working on Chrome, so my original PR is closed until I can figure that out. Here's a link to where I left off in case anyone else happened to be interested.

shivam4799 added a commit to shivam4799/water.css that referenced this issue Oct 12, 2019
shivam4799 added a commit to shivam4799/water.css that referenced this issue Oct 12, 2019
@kylejrp
Copy link
Collaborator

@kylejrp kylejrp commented Nov 2, 2019

There was a pull request for this on #128, but it was closed because it used IDs/classes. This is still up for grabs if that pull request doesn't get reopened.

Don't forget that @asoback had an excellent WIP here:
https://github.com/asoback/water.css/blob/progressbar/src/parts/_misc.css

@dimshik100
Copy link

@dimshik100 dimshik100 commented Oct 1, 2020

Hi
I want to try and add support for this.
Can you please assign me?

@kognise
Copy link
Owner

@kognise kognise commented Oct 1, 2020

@dimshik100 done- good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.