close
The Wayback Machine - https://web.archive.org/web/20201007140431/https://github.com/ngrx/platform/issues/1825
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document createSelectorFactory #1825

Open
alex-okrushko opened this issue May 6, 2019 · 7 comments
Open

document createSelectorFactory #1825

alex-okrushko opened this issue May 6, 2019 · 7 comments

Comments

@alex-okrushko
Copy link
Member

@alex-okrushko alex-okrushko commented May 6, 2019

Currently docs are missing that info:

  • how createSelectorFactory can be used to better select arrays
  • what could be used instead of defaultMemoize

Other information:

I would be willing to submit a PR for the docs ❤️

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented May 6, 2019

Is this a dup of #1217 ?

@alex-okrushko alex-okrushko changed the title document createSelectorFactory and how it can be used to better select arrays document createSelectorFactory May 6, 2019
@alex-okrushko
Copy link
Member Author

@alex-okrushko alex-okrushko commented May 6, 2019

Interesting. I think that issue was open with the intention of adjusting the API. I think that one can be closed.

I updated this issue with what would ideally be mentioned in the docs. :)

@UserGalileo
Copy link

@UserGalileo UserGalileo commented May 8, 2019

I'm sorry, I didn't have enough time at the time I opened that issue. I had started to put down some lines but I stopped because of 1) lack of time, 2) was still trying to figure out part of the source code, 3) I saw some commits that made me believe that module would have changed relatively fast (don't know why but it gave me the feeling to be something internal and not ready for the public yet, but It's been months :))

I wouldn't like to disappoint you all by saying that I'll do It, but I'd be happy to partecipate to this discussion :) I'll try to find my files from months ago to tell you what felt "strange" to me!

@alex-okrushko
Copy link
Member Author

@alex-okrushko alex-okrushko commented May 9, 2019

I think Asif (@daem0ndev) is looking into contributing to this part of the docs.

@daem0ndev
Copy link

@daem0ndev daem0ndev commented May 9, 2019

Working on this!

@alex-okrushko
Copy link
Member Author

@alex-okrushko alex-okrushko commented Sep 15, 2020

We are still looking for a contributor for this part of the docs 🙂

@santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Sep 15, 2020

Cool, I will take it @alex-okrushko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.