close
The Wayback Machine - https://web.archive.org/web/20201024145821/https://github.com/revery-ui/revery/issues/873
Skip to content

/ revery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Improve DX by adding more named arguments to Skia-bindings #873

Open
lessp opened this issue Jun 1, 2020 · 1 comment
Open

API: Improve DX by adding more named arguments to Skia-bindings #873

lessp opened this issue Jun 1, 2020 · 1 comment
Labels
A-other good first issue

Comments

@lessp
Copy link
Member

@lessp lessp commented Jun 1, 2020

Since we also expose the Skia-bindings for a Canvas-like API I think it might be a good idea to start refactoring the API to utilise more named arguments e.g. ~x=..., ~y=....

What do you others think?
@lessp lessp added the A-other label Jun 1, 2020
@lessp lessp changed the title API: Improve DX by adding more named arguments to reason-skia API: Improve DX by adding more named arguments to Skia-bindings Jun 1, 2020
@glennsl
Copy link
Member

@glennsl glennsl commented Jun 1, 2020

Yes please! I'm working with the Skia/Canvas API right now, and needing to look up what the umpteen different float arguments of a function means is definitely a frustrating experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-other good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@glennsl @lessp
You can’t perform that action at this time.