close
The Wayback Machine - https://web.archive.org/web/20220526095457/https://github.com/abhijithneilabraham/tableQA/issues/23
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Support more dataframes #23

Open
abhijithneilabraham opened this issue Sep 25, 2020 · 24 comments
Open

* Support more dataframes #23

abhijithneilabraham opened this issue Sep 25, 2020 · 24 comments
Labels
good first issue

Comments

@abhijithneilabraham
Copy link
Owner

@abhijithneilabraham abhijithneilabraham commented Sep 25, 2020

-Currently the feature supports csv files only. However, integrating more dataframes is easy. Go through the get_dataframe() method in data_utils.py and include support to detect the incoming file and parse the dataframe from it.

@abhijithneilabraham abhijithneilabraham added the good first issue label Sep 25, 2020
@rhamnett
Copy link

@rhamnett rhamnett commented Sep 26, 2020

It'd be good to just be able to do something like:

agent = Agent(df)

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Sep 26, 2020

It'd be good to just be able to do something like:

agent = Agent(df)

Sure. We will update it asap.

@rhamnett
Copy link

@rhamnett rhamnett commented Sep 26, 2020

@abhijithneilabraham keep up the great work, looking forward to contributing

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Sep 26, 2020

Thanks! @rhamnett The repo is updated with the changes you suggested, kindly go through the readme and examples and report any bugs.

@rhamnett
Copy link

@rhamnett rhamnett commented Sep 27, 2020

Hello @abhijithneilabraham! That's great! I gave it a quick test on a sample dataset i created from my own columns and the basic functionality seems to work!

Some support for date types etc - datetime64 etc would be really good and then getting the model to understand what today/yesterday/this week/last week means from the current date.

agent.query_db("how many website visits were there in the last week?")
agent.query_db("how many orders have I had today?")
agent.query_db("how many orders have I had for the week beginning 31st August 2020?")

This kind of thing 👍

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Sep 27, 2020

Makes sense. In fact, I was already building something like that, but the issue is to map the natural language to datetime without approaching it in a rule based way. Let me think about this and will update asap.

@rhamnett
Copy link

@rhamnett rhamnett commented Sep 27, 2020

Makes sense. In fact, I was already building something like that, but the issue is to map the natural language to datetime without approaching it in a rule based way. Let me think about this and will update asap.

Yes, that's whats going to make it interesting :)

@TheurgicDuke771
Copy link

@TheurgicDuke771 TheurgicDuke771 commented Dec 15, 2020

Hi,
What will be the df when use MySQL db (have multiple table)?

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Dec 15, 2020

Haven't implemeted multi-table support yet. We need to join tables in that case, it seems. Will plan that for future. Thanks 😊 .

@TheurgicDuke771
Copy link

@TheurgicDuke771 TheurgicDuke771 commented Dec 15, 2020

thanks for the quick reply. Then df should be select * from table, right?

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Dec 15, 2020

That's correct. Download a table as a dataframe and pass it to this.

You could also contribute a feature if you can enable something like agent=Agent(db_url, table_name). Refer agent.py,data_utils.py

@TheurgicDuke771
Copy link

@TheurgicDuke771 TheurgicDuke771 commented Dec 15, 2020

Sure, will check that. And send you a pr if get anything solid.

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Dec 15, 2020

Thanks!

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Dec 19, 2020

Hello @abhijithneilabraham! That's great! I gave it a quick test on a sample dataset i created from my own columns and the basic functionality seems to work!

Some support for date types etc - datetime64 etc would be really good and then getting the model to understand what today/yesterday/this week/last week means from the current date.

agent.query_db("how many website visits were there in the last week?")
agent.query_db("how many orders have I had today?")
agent.query_db("how many orders have I had for the week beginning 31st August 2020?")

This kind of thing 👍

This has been done too! We have a Date class in column_types.py

@dharmesh2002
Copy link

@dharmesh2002 dharmesh2002 commented Apr 18, 2022

Hi Abhijit
Have used this tool, it is an excellent tool.
Have tested some of my scenarios, they are working fine. Have one query, do joins works in this tool like left join or right join

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Apr 18, 2022

Hi @dharmesh2002 , Can you be more specific where you have tested a scenario with SQL joins?

@dharmesh2002
Copy link

@dharmesh2002 dharmesh2002 commented Apr 19, 2022

Hi @abhijithneilabraham , i haven't tested sql queries, what i need is, to connect sql and than to join with tables. So that's why i was checking with you whether that is feasible?

@dharmesh2002
Copy link

@dharmesh2002 dharmesh2002 commented Apr 21, 2022

@abhijithneilabraham - is it possible to add new functions like group by or having clause?

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Apr 21, 2022

@dharmesh2002
Copy link

@dharmesh2002 dharmesh2002 commented Apr 21, 2022

@abhijithneilabraham sorry I didn’t understood, can u pls help me where to add group by function, I tried adding but it didn’t work

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Apr 21, 2022

@dharmesh2002 Can you make a pull request with your code and tag it here?

@snehithakrishna2
Copy link

@snehithakrishna2 snehithakrishna2 commented Apr 21, 2022

@dharmesh2002 Can you make a pull request with your code and tag it here?
hi,
@abhijithneilabraham #61

@dharmesh2002
Copy link

@dharmesh2002 dharmesh2002 commented Apr 22, 2022

@abhijithneilabraham please if you can have a look on pool request we shared above

@abhijithneilabraham
Copy link
Owner Author

@abhijithneilabraham abhijithneilabraham commented Apr 22, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue
Projects
None yet
Development

No branches or pull requests

5 participants