Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Allow the graph to follow the container vertical resize #2376
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2376 +/- ##
==========================================
- Coverage 77.23% 77.22% -0.01%
==========================================
Files 51 51
Lines 4138 4137 -1
==========================================
- Hits 3196 3195 -1
Misses 942 942
Continue to review full report at Codecov.
|
|
Hi @jsiembida, thanks for the contribution. Tests are required for pull requests, it ensures the changes are working as expected and serve as documentation on how the library is supposed to behave for future contributors. Did you find out why |
Hello,
Observed behavior:
When changing the vertical window size the chart only updates towards
smaller height (can only shrink). When the window is getting higher, the chart
stays at the last height. The horizontal resizing works as expected.
This is CodePen (couldn't reproduce it using jsFiddle) of the original C3:
https://codepen.io/anon/pen/aGewNy
This is CodePen with the fix applied:
https://codepen.io/anon/pen/qYejZp
Please drag the horizontal bar up and down and observe how chart follows the resizing.
regards,
jarek