close
The Wayback Machine - https://web.archive.org/web/20240616144608/https://github.com/microsoft/winget-pkgs/issues/3201
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio Code System Wide Installer Package #3201

Closed
mhm13dev opened this issue Aug 22, 2020 · 15 comments
Closed

Add Visual Studio Code System Wide Installer Package #3201

mhm13dev opened this issue Aug 22, 2020 · 15 comments
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Help-Wanted This is a good candidate work item from the community.
Milestone

Comments

@mhm13dev
Copy link
Contributor

I am tagging @lszomoru because he is maintaining the VS Code Package.

As we have packages for VisualStudioCode and VisualStudioCodeInsiders but they both are the user installers. I want you to please add a System wide installer for both of these packages.

Package Requested

Manifest: VisualStudioCodeSystem

Fill out as much of the manifest as you can:

Id: string # Microsoft.VisualStudioCodeSystem
Publisher: Microsoft Corporation
Name: Visual Studio Code - System Installer
Version: 1.48.1.3dd905126b
License: Copyright (c) Microsoft Corporation
InstallerType: string # enumeration of supported installer types (exe, msi, msix, inno, wix, nullsoft, appx)
Installers:
  - Arch: string # enumeration of supported architectures
    Url: string # path to download installation file
    Sha256: string # SHA256 calculated from installer
# ManifestVersion: 0.1.0
@mhm13dev mhm13dev added the Help-Wanted This is a good candidate work item from the community. label Aug 22, 2020
@ghost ghost added the Needs: Triage label Aug 22, 2020
@mhm13dev mhm13dev changed the title Add vscode machine wide installer package Add Visual Studio Code System Wide Installer Package Aug 22, 2020
@yigitemres
Copy link
Contributor

yigitemres commented Aug 24, 2020

Gonna add it. Thanks for the suggestion.

Edit: @mhm13dev Done it. 🥂

@lszomoru
Copy link
Member

Thanks for tagging me. Publishing the winget package is done though our release pipeline so rather than adding these packages manually, let me update our release pipeline to start publishing the system packages as well. I have filed an issue in the vscode repo to complete this work - microsoft/vscode#105307.

@yigitemres
Copy link
Contributor

@lszomoru If that's the case, probably my manual pr rejected. I'm gonna close my own pr. Thanks for hard work! 🥂

@denelon
Copy link
Contributor

denelon commented Oct 19, 2020

I think we're going to need microsoft/winget-cli#149 to be able to have "both" types of installers available.

@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Oct 19, 2020
@lszomoru
Copy link
Member

We actually have two separate setup packages for System/User so the current plan is to start publishing the manifest for the system setup along with the user setup. It is on our backlog and I hope to get to it in the month of November. Apologies for the delay.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 6, 2021
@ghost
Copy link

ghost commented Jan 6, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@alec-hs
Copy link

alec-hs commented Jan 28, 2021

@lszomoru is there any update on the status of the system wide installer?

@ghost ghost removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 28, 2021
@lszomoru
Copy link
Member

@alec-hs, apologies for the delay on this one. I will try to tackle this one next week.

@lszomoru
Copy link
Member

lszomoru commented Feb 2, 2021

I have updated our release pipeline and now we are publishing User/System installers for x86 and x64.
Please run winget search vscode to see the available packages. Let me know if you have any questions or concerns.

@alec-hs
Copy link

alec-hs commented Feb 2, 2021

Just tested - seems all good. Thanks for the quick turn around!

@denelon
Copy link
Contributor

denelon commented Apr 1, 2021

We're working on microsoft/winget-cli#149 User vs. System. Once that's in place, Visual Studio Code and Visual Studio Code Insiders can go back to being a single package with multiple installers (I hope 😄). We will need to do some local testing to make sure things are correctly supported.

@lszomoru
Copy link
Member

@denelon, I believe that his issue has been resolved and it can be closed. Thanks!

@denelon denelon closed this as completed Jun 28, 2021
@556556bt
Copy link

I just tried and it installed as user scope instead of system-wide.
ver: 1.65.2

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Mar 14, 2022

I just tried and it installed as user scope instead of system-wide. ver: 1.65.2

Run winget install Microsoft.VisualStudioCode --scope machine

For more info on what parameters you can pass to the winget install command, you can do winget install -?:
image

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
@IntNinja
Copy link

I just tried and it installed as user scope instead of system-wide. ver: 1.65.2

Run winget install Microsoft.VisualStudioCode --scope machine

For more info on what parameters you can pass to the winget install command, you can do winget install -?: image

it still just installs it as user scope, i've verified the url and it's the same with and without --scope machine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Help-Wanted This is a good candidate work item from the community.
Projects
None yet
Development

No branches or pull requests

8 participants