Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixture: Legacy JSX Runtimes #20012
Merged
Fixture: Legacy JSX Runtimes #20012
+15,740
−1
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a58529b:
|
|
Great stuff!! |
gaearon
merged commit 6d50a9d
into
facebook:master
2 of 10 checks passed
2 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds checked-in bundles for JSX runtimes for different stable React versions. Those were edited by hand.
Each comes with an integration testing suite adjusted for that version.
They look like this:
The regression suite contains a lint step and some hand-picked tests adapted from different existing ones in the repo. We run in three configurations:
jsxDEV in DEV,jsx in DEV, andjsx in PROD.Differences Between Bundles
Each lower bundle is based on the higher one.
object-assignfrom the output.ReactComponentTreeHook.instance.getName()in messages. ReadReactCurrentOwnerfromreact/lib/.