close
The Wayback Machine - https://web.archive.org/web/20220423200455/https://github.com/nodejs/node/pull/35756
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.x] doc: fix Node.js 14.x changelogs #35756

Merged
merged 1 commit into from Oct 22, 2020

Conversation

Copy link
Member

@richardlau richardlau commented Oct 22, 2020

Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.


I'd like to fast track this, if possible, so that it can land with #35746.
cc @nodejs/releasers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@richardlau richardlau added dont-land-on-v10.x dont-land-on-v12.x labels Oct 22, 2020
@nodejs-github-bot nodejs-github-bot added meta v14.x labels Oct 22, 2020
@richardlau richardlau mentioned this pull request Oct 22, 2020
4 tasks
@richardlau
Copy link
Member Author

@richardlau richardlau commented Oct 22, 2020

Please 👍 to fast track.

@richardlau richardlau added the fast-track label Oct 22, 2020
Copy link
Member

@MylesBorins MylesBorins left a comment

LGTM

Remove the table headings for Node.js 13.x that were not removed in
631dd21.

Vertically align the list of releases in the 14.x changelog as they
are in the changelogs for 12.x and 10.x.

PR-URL: nodejs#35756
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau merged commit 90a5d59 into nodejs:v14.x-staging Oct 22, 2020
12 checks passed
@richardlau
Copy link
Member Author

@richardlau richardlau commented Oct 22, 2020

Landed in 90a5d59.

@richardlau richardlau deleted the v14.xchangelog branch Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v12.x fast-track meta v14.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants