Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow multiple data files as input #1895
Comments
|
In this situation only Yes, this seems counter intuitive. Handling the positional parameter in combination with the named parameter has been kind of tricky. I do agree, this seems like a bug. Not 100% sure how to deal with it yet. |
|
So I think what could be done here is support multiple data files as input, and then if none of the files are able to be opened them VW will exit with a non-zero return code. You would also need to pass |
|
+1 to supporting multiple data files as inputs. |
jackgerrits
changed the title
|
#2355 additionally proposed support for globbing as well as passing a directory to the -d option. |
|
@jackgerrits Is anyone working on this issue? |
|
No, you're welcome to work on this |
Describe the bug
Call vw with a bad argument and notice that vw does not return a non-zero error code. To detect whether vw rejected the arguments would require us to read the output and look for a line that says "sailing on!" .. which is not really a robust mechanism to return an error response.
To Reproduce
Steps to reproduce the behavior:
For example (notice the vw parameters are "bad vw arguments" which are invalid parameters):
VW COMMAND:
E:\sharathm\github\sharathmalladi-mwt-ds\DataScience>vw bad vw arguments -d D:/tmp/124bb2ca-a99f-489e-b29c-bc142baa6f51\6359742a010048a58c1892eabd731d4c\6359742a010048a58c1892eabd731d4c_merged_data_2019-01-03_2019-01-03.json.gz -p D:/tmp/124bb2ca-a99f-489e-b29c-bc142baa6f51\6359742a010048a58c1892eabd731d4c\6359742a010048a58c1892eabd731d4c_merged_data_2019-01-03_2019-01-03.json.gz.Custom Policy 1.pred predictions = D:/tmp/124bb2ca-a99f-489e-b29c-bc142baa6f51\6359742a010048a58c1892eabd731d4c\6359742a010048a58c1892eabd731d4c_merged_data_2019-01-03_2019-01-03.json.gz.Custom
Num weight bits = 18
learning rate = 0.5
initial_t = 0
power_t = 0.5
using no cache
Reading datafile = bad
can't open 'bad', sailing on!
num sources = 0
average since example example current current current
loss last counter weight label predict features
finished run
number of examples = 0
weighted example sum = 0.000000
weighted label sum = 0.000000
average loss = n.a.
total feature number = 0
E:\sharathm\github\sharathmalladi-mwt-ds\DataScience>echo %ERRORLEVEL%
0
Expected behavior
The error code after invoking vw should be non-zero since vw did not successfully output the predictions.
Observed Behavior
We instead get back an output that has a line that reads:
can't open 'bad', sailing on!
Environment
What version of VW did you use?
8.6.1
What OS or language did you use?
Windows command line
Additional context
None