close
The Wayback Machine - https://web.archive.org/web/20201101214356/https://github.com/rust-lang/rust/pull/78137
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize tracing subscriber in compiletest tool #78137

Merged
merged 1 commit into from Oct 26, 2020

Conversation

@tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Oct 20, 2020

The logging in compiletest was migrated from log crate to a tracing, but
the initialization code was never changed, so logging is non-functional.

Initialize tracing subscriber using default settings.

The logging in compiletest was migrated from log crate to a tracing, but
the initialization code was never changed, so logging is non-functional.

Initialize tracing subscriber using default settings.
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Oct 20, 2020

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Oct 25, 2020

@bors r+

@bors
Copy link
Contributor

@bors bors commented Oct 25, 2020

📌 Commit 08d5e96 has been approved by Mark-Simulacrum

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 26, 2020
…-Simulacrum

Initialize tracing subscriber in compiletest tool

The logging in compiletest was migrated from log crate to a tracing, but
the initialization code was never changed, so logging is non-functional.

Initialize tracing subscriber using default settings.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Oct 26, 2020
…-Simulacrum

Initialize tracing subscriber in compiletest tool

The logging in compiletest was migrated from log crate to a tracing, but
the initialization code was never changed, so logging is non-functional.

Initialize tracing subscriber using default settings.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#74477 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm)
 - rust-lang#77283 (Tweak `if let` suggestion to be more liberal with suggestion and to not ICE)
 - rust-lang#77836 (transmute_copy: explain that alignment is handled correctly)
 - rust-lang#78137 (Initialize tracing subscriber in compiletest tool)
 - rust-lang#78161 (Add issue template link to IRLO)
 - rust-lang#78214 (Tweak match arm semicolon removal suggestion to account for futures)
 - rust-lang#78227 (Capture output from threads spawned in tests)
 - rust-lang#78247 (Fix rust-lang#78192)
 - rust-lang#78268 (Do not try to report on closures to avoid ICE)

Failed merges:

 - rust-lang#78104 (BTreeMap: ban BoxedNode from Root)

r? `@ghost`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 26, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#74477 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm)
 - rust-lang#77836 (transmute_copy: explain that alignment is handled correctly)
 - rust-lang#78126 (Properly define va_arg and va_list for aarch64-apple-darwin)
 - rust-lang#78137 (Initialize tracing subscriber in compiletest tool)
 - rust-lang#78161 (Add issue template link to IRLO)
 - rust-lang#78214 (Tweak match arm semicolon removal suggestion to account for futures)
 - rust-lang#78247 (Fix rust-lang#78192)
 - rust-lang#78252 (Add codegen test for rust-lang#45964)
 - rust-lang#78268 (Do not try to report on closures to avoid ICE)
 - rust-lang#78295 (Add some regression tests)

Failed merges:

r? `@ghost`
@bors bors merged commit efbbdac into rust-lang:master Oct 26, 2020
11 checks passed
11 checks passed
auto Run timed out
Details
auto-fallible Run timed out
Details
bors build finished Run timed out
Details
bors build finished Run timed out
Details
bors build finished Run timed out
Details
bors build finished Run timed out
Details
master Run timed out
Details
try Run timed out
Details
PR (mingw-check, ubuntu-latest-xl)
Details
PR (x86_64-gnu-llvm-8, ubuntu-latest-xl)
Details
PR (x86_64-gnu-tools, 1, ubuntu-latest-xl)
Details
@rustbot rustbot added this to the 1.49.0 milestone Oct 26, 2020
@tmiasko tmiasko deleted the tmiasko:compiletest-tracing branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.