close
The Wayback Machine - https://web.archive.org/web/20201203161230/https://github.com/plouc/nivo/issues/1153
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar legend labels are not visible in dark theme #1153

Open
kumarunster opened this issue Oct 9, 2020 · 3 comments
Open

Calendar legend labels are not visible in dark theme #1153

kumarunster opened this issue Oct 9, 2020 · 3 comments

Comments

@kumarunster
Copy link

@kumarunster kumarunster commented Oct 9, 2020

Calendar legend labels are not visible in dark theme

To Reproduce

  1. Go to https://nivo.rocks/calendar/
  2. Click on 'light/dark' switch and enable dark mode
  3. See legend texts

Expected behavior
legend texts should have same fill color as year/month labels and be at least visible

Screenshots

Bildschirmfoto 2020-10-09 um 15 35 53

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser [chroe, safari, firefox]
@wyze
Copy link
Collaborator

@wyze wyze commented Oct 20, 2020

Thanks, a PR would be welcomed. If anyone would like to tackle it!

@diegosps
Copy link
Contributor

@diegosps diegosps commented Oct 28, 2020

As a workaround:

<ResponsiveCalendar
    theme={{
            ///...
            labels: { text: { fill: theme.palette.text.primary } }
    }}
/>

Im my case, theme is material ui and the value for primary changes according to dark/light theme.

But I agree this should be fixed in the component.

@kumarunster
Copy link
Author

@kumarunster kumarunster commented Oct 28, 2020

I'm trying to prepare a PR for this. I saw, that the same issue occurs on other legends too. More, with last release the legends disappear at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.