close
The Wayback Machine - https://web.archive.org/web/20201004183701/https://github.com/plouc/nivo/issues/931
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support d3-scale nice #931

Open
CharlieMartell opened this issue Apr 20, 2020 · 0 comments
Open

Support d3-scale nice #931

CharlieMartell opened this issue Apr 20, 2020 · 0 comments

Comments

@CharlieMartell
Copy link

@CharlieMartell CharlieMartell commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
Currently if the domain of a continuous scale is say [1050, 1500] the scale will return tickvalues/gridvalues that do not include the full domain. If you use https://github.com/d3/d3-scale#continuous_nice it will include the full domain in the tickvalues

Describe the solution you'd like
Allow us to pass a prop in the yScaleSpec, xScaleSpec to include full domain in the ticks computed.

Describe alternatives you've considered
I manually computed tickValues and gridValues for a chart after creating a "nice" domain. But then the axis labels get messed up because the axis labels are being plotted to a scale computed by nivo which doesn't use the "nice" domain so it will put labels inside the chart.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.