Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLine numbers off when using compiled files #10
Comments
|
Sorry for the very very very quite late response to this issue :) i've been busy with other stuff to take care of this package. Basically atom-mocha spins up a separate node process that runs the tests and uses a custom mocha reporter to communicate stuff back to the ui. it does not prepend anything in to code, but if the compiler setting is set to anything other then ES5 it does a require("bable/register") or require("coffeescript/register") based on what settings is used, in the separate process. I'm not exactly sure how or if i can set it to use other compilers that are not installed directly in the package. If you have any ideas they are more then welcome. Until then if switching to ES5 compiler setting, go forth and use that :P. Cheers, |
First of all: thanks for this great package! Really like having a clean overview of all tests in the panel, and having clickable stack-traces is very handy!
I did run into two issues there, though: first, I ran into #5, which I hacked in the source by prepending my home dir before the file path for now. That's probably not the right solution though, and it may actually be a bug/feature in the
error-stack-framepackage.Then, it appeared that the line numbers in the file were off by 30 rows. After some poking around, I think it is caused by my .js file being a compiled file (using Typescript). I'm using
source-map-supportfor translating the .js line numbers back to .ts line numbers (throughimport "source-map-support/register";at the top of the .ts/.js file), but it seems that some code is prepended to the .js file before it's run through mocha. This causes the line numbers to be higher than expected, which then causes source-map-support to translate to the wrong line.I then found the
compilersetting, and noticed that by setting it to "ES5", the problem no longer occurs.Maybe there's a different way of prepending the babel stuff, or using ES5 as the default setting?