Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add environment variables to control cors configuration in docker images #59
Comments
|
Is there any reason to add more than "allowed origins"? I'd assume that browser apps should only fetch packages/components. Maybe even the default should be "*", since it's very similar to how browser fetch scripts/components from works from different domains. |
|
Using * as the default definitely makes sense. I guess that allowed origins are the only thing that makes sense to configure. I’d say that most users indeed will go with a catch-all configuration. Bottom line: I think you’re right :) |
The image uses the cors package from npm. The package is really configurable, check out
cors on npm. We need to think which configurations make sense and what is the best way to allow people to control them. If #58 is done before this it might affect the solution to this issue.