close
The Wayback Machine - https://web.archive.org/web/20201107122324/https://github.com/radareorg/radare2/issues/17505
Skip to content

/ radare2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide between `_MSC_VER` and `__WINDOWS__` #17505

Open
XVilka opened this issue Aug 21, 2020 · 5 comments
Open

Decide between `_MSC_VER` and `__WINDOWS__` #17505

XVilka opened this issue Aug 21, 2020 · 5 comments
Assignees
@karliss @kazarmy @a1ext @GustavoLCR
Labels
Windows good first issue refactor
Projects
Refactorings Windows

Comments

@XVilka
Copy link
Member

@XVilka XVilka commented Aug 21, 2020

Currently we use both, but it's probably wrong:

radare2 on  master [$?] 
[i] ℤ rg __WINDOWS__ | wc -l                                                                                                                                                                                                       17:44:21 
377
radare2 on  master [$?] 
[i] ℤ rg _MSC_VER | wc -l                                                                                                                                                                                                          17:44:42 
178
@a1ext
Copy link
Member

@a1ext a1ext commented Aug 21, 2020

@XVilka _MSC_VER is available for Visual Studio's compiler only. __WINDOWS__ is wider. You should decide where and which of them have to be used. Actually I cannot handle this issue, so I suggest you to reassign it to somebody else.
@kazarmy
Copy link
Collaborator

@kazarmy kazarmy commented Aug 21, 2020

clang-cl also defines _MSC_VER, and it and MSVC are the only 2 compilers on Windows that we care about, right?
@a1ext
Copy link
Member

@a1ext a1ext commented Aug 21, 2020

clang-cl also defines _MSC_VER, and it and MSVC are the only 2 compilers on Windows that we care about, right?

didn't know about such behavior of clang-cl
@trufae
Copy link
Contributor

@trufae trufae commented Sep 10, 2020

imho mscver is about the cocmpiler and windows about the OS. totally different things. if mingw and cygwin was removed from the support i dont see why we shuold have compiler specific things. and if we do it should be the minimum amount of them
@ret2libc
Copy link
Collaborator

@ret2libc ret2libc commented Sep 10, 2020

I agree with pancake, can we close this @XVilka ?
@XVilka XVilka added this to To do in Windows via automation Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karliss karliss

@kazarmy kazarmy

@a1ext a1ext

@GustavoLCR GustavoLCR

Labels
Windows good first issue refactor
Projects
Refactorings
  
Awaiting triage
Windows
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
@XVilka @ret2libc @trufae @karliss @kazarmy @a1ext @GustavoLCR
You can’t perform that action at this time.