close
The Wayback Machine - https://web.archive.org/web/20201109102649/https://github.com/gatsbyjs/gatsby/issues/27308
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to remove the scroll position (@@scroll/initial etc) in session storage? #27308

Open
isshesure opened this issue Oct 6, 2020 · 9 comments

Comments

@isshesure
Copy link

@isshesure isshesure commented Oct 6, 2020

Currently, the user's scroll position is stored within session storage, and this is violating a GDPR compliance check (yes, I know). Is there a way to disable this storage?

@herecydev
Copy link
Collaborator

@herecydev herecydev commented Oct 6, 2020

Is storing a position in a page anywhere close to "uniquely identifying a user"? I'm no expert but this seems fine?

@devbhansingh
Copy link

@devbhansingh devbhansingh commented Oct 7, 2020

I would like to contribute in this project.

@isshesure
Copy link
Author

@isshesure isshesure commented Oct 7, 2020

Yes, it's more that it fails some online compliance checks, and given that I'm using shouldUpdateScroll to ignore the scroll position, it's also redundant. Perhaps this should be a feature request to update shouldUpdateScroll to be a more generic scrolling override option.

@herecydev
Copy link
Collaborator

@herecydev herecydev commented Oct 7, 2020

So this file is the relevant one: https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-react-router-scroll/src/scroll-handler.tsx

As it's just a React context you should be able to override the default by providing your own Provider. Does that work?

@ascorbic
Copy link
Member

@ascorbic ascorbic commented Oct 8, 2020

I am not a lawyer, but I have worked quite a bit with the GDPR. There is no scenario where scroll position could be considered to be PII! That said, it is a reasonable feature request so if someone wants to contribute then please go ahead. Are you planning to do this, @devbhansingh ?

@Shock451
Copy link

@Shock451 Shock451 commented Oct 10, 2020

Hi, I'd like to take up this issue.

@lnfnunes
Copy link

@lnfnunes lnfnunes commented Oct 12, 2020

A ref doc about this subject: https://www.termsfeed.com/blog/gdpr-scrolling-not-consent/
As @ascorbic mentioned, I'm not a lawyer too and my understanding is the scrolling act on a webpage cannot be considered consent. This is a reasonable feature but not because of GDPR compliance.

@RobvH
Copy link

@RobvH RobvH commented Oct 20, 2020

It might be worth clarifying for all the non-Europeans, like myself, who were still confused after reading to this point. The implied issue here is that scroll position is kept in session storage and the implementation of that session storage is using cookies. So this is running afoul of a requirement that the user consent to the use of HTTP cookies.

Also, I'm not a lawyer. And whoever made this law wasn't a web developer ;)

@RobvH
Copy link

@RobvH RobvH commented Oct 20, 2020

Are there tests around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.