Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
This repository has been archived by the owner. It is now read-only.
Issue #824: Convert tests from JavaScript to TypeScript #826
Conversation
|
Thanks a lot. I am still not convinced it was worth it seeing |
|
Requested changes made, and all CI checks have passed. I think we are ready. |
|
@ynejati you changes has bean approved, after you fix the conflicts you should be able to hit the merge |
|
Cool! Thanks @Bnaya. |
# Conflicts: # package.json
|
@Bnaya, I ran prettier over your files after converting to TS. I hope you don't mind. |
|
Hahaha.. darn it @FredyC . No problem. I'll resolve conflicts later today. |
|
Thanks for the great work @ynejati |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Converting tests from JS to TS, picking up where the src JS to TS conversion left off.