close
The Wayback Machine - https://web.archive.org/web/20201104075446/https://github.com/renovatebot/renovate/issues/6224
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid link in git hash updates for npm #6224

Open
ad-m opened this issue May 13, 2020 · 7 comments
Open

Invalid link in git hash updates for npm #6224

ad-m opened this issue May 13, 2020 · 7 comments

Comments

@ad-m
Copy link

@ad-m ad-m commented May 13, 2020

What Renovate type are you using?

GitHub App

Describe the bug

Link in pull-requests like watchdogpolska/small_eod#324 point to invalid URL for changes ( https://renovatebot.com/diffs/npm/small_eod_client//).

Did you see anything helpful in debug logs?

Not applicable.

To Reproduce

Use npm & pull package directly from Git repository.

Additional context

See changes https://github.com/watchdogpolska/small_eod/pull/324/files .

@rarkins
Copy link
Collaborator

@rarkins rarkins commented May 14, 2020

Solution: we should skip embedding this diff link if the updateType is digest

@ad-m
Copy link
Author

@ad-m ad-m commented May 14, 2020

Why not fix that link eg. via link to https://github.com/watchdogpolska/small-eod-sdk-javascript/compare/9e3dc07...45a3053?

@rarkins
Copy link
Collaborator

@rarkins rarkins commented May 14, 2020

It's a good idea, if the implementer has time to do it all in one go.

@rarkins
Copy link
Collaborator

@rarkins rarkins commented May 14, 2020

Can you create a simple reproduction repo that can be used to test against? e.g. like your real repo was before you merged the PR, and ideally just one dependency so that it doesn't get messy in the logs.

@ad-m
Copy link
Author

@ad-m ad-m commented May 14, 2020

@rarkins rarkins added this to Ready in Renovate Jun 18, 2020
@rarkins rarkins removed the ready label Jun 18, 2020
@ad-m
Copy link
Author

@ad-m ad-m commented Aug 27, 2020

@massto , what do you mean? Are you a bot? I am bit lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Renovate
  
Ready
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@JamieMagee @ad-m @rarkins and others
You can’t perform that action at this time.