Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add "resolv-conf" flag to Kubelet for CoreDNS #395
Merged
Conversation
For systemd-resolvd based systems, core-DNS will fail to start. Using moby/libnetwork, we can detect that, and point kubelet to the real DNS config file. Signed-off-by: Karen Almog <kalmog@mirantis.com>
Signed-off-by: Karen Almog <kalmog@mirantis.com>
trawler
requested review from
soider,
jnummelin and
ncopa
and removed request for
k0sproject/k0s-core
|
Tested it with multipass and it worked out of the box. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue
Fixes #390
What this PR Includes
This PR removes the need for "hacking" the
resolv.conffile in systemd-resolvd systems, by finding out the "real" resolv.conf file and passing it as the value for the--resolv-confflag in kubelet.e2e✅
https://github.com/k0sproject/k0s/actions/runs/361469902