close
The Wayback Machine - https://web.archive.org/web/20201004074354/https://github.com/awslabs/s2n/issues/1476
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEMs with keyword TRUSTED CERTIFICATE #1476

Open
raycoll opened this issue Jan 24, 2020 · 2 comments
Open

Support PEMs with keyword TRUSTED CERTIFICATE #1476

raycoll opened this issue Jan 24, 2020 · 2 comments

Comments

@raycoll
Copy link
Collaborator

@raycoll raycoll commented Jan 24, 2020

Problem:

Openssl may generate certificate PEM files that include TRUSTED CERTIFICATE as the PEM keyword. Currently s2n only supports CERTIFICATE as the PEM keyword. I don't think this is a typical thing to have in a server certificate chain since it is apparently only added to certs with root trust properties, but it doesn't hurt to at least support them for TLS server purposes(s2n does not parse or on any of the properties of certificates beyond the leaf).

Proposed Solution:

Allow PEMs to be parsed that use this keyword in the PEM delimiters.

@raycoll raycoll changed the title Support PEMs with keyword `TRUSTED CERTIFICATE` Support PEMs with keyword TRUSTED CERTIFICATE Jan 24, 2020
@raycoll
Copy link
Collaborator Author

@raycoll raycoll commented Jan 24, 2020

I was working on #1474 and had to manually change the root cert's keyword from TRUSTED CERTIFICATE to just CERTIFICATE.

@raycoll
Copy link
Collaborator Author

@raycoll raycoll commented Jan 24, 2020

I tried this patch, which seemed to work immediately, but I'm not sure if this is the best approach: raycoll@6c34bb5

@zaherd zaherd added this to To do in General Enhancements via automation Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.