close
The Wayback Machine - https://web.archive.org/web/20201125090134/https://github.com/wordpress-mobile/WordPress-Android/issues/10940
Skip to content

/ WordPress-Android

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: learn more element should be combined into a single focusable element #10940

Open
designsimply opened this issue Dec 10, 2019 · 9 comments
Open

Settings: learn more element should be combined into a single focusable element #10940

designsimply opened this issue Dec 10, 2019 · 9 comments
Labels
Accessibility Site Settings TalkBack [Type] Bug good first issue

Comments

@designsimply
Copy link
Contributor

@designsimply designsimply commented Dec 10, 2019

Steps to reproduce:

  1. Go to Settings > Accessibility > TalkBack > "Use service" or use the Volume key shortcut.
  2. In the WordPress app, go to My Sites > Settings > More.
  3. Swipe right to find the "Learn More" element.

Result: (48s)

This part of the Settings – More screen contains two elements that are focusable for TalkBack: (1) the text field, and (2) the learn more button. TalkBack reads the text of the first element (“You can…”) and finishes with “double tap to activate, double tap and hold to long press.” Double-tapping does nothing, however. Double tapping and holding opens a popup dialog. If the learn more button is focused, double tapping opens the same dialog. This could be improved by combining these two focusable elements into a single focusable element that opens the relevant dialog if activated.

learn-more-element

Tested with WPAndroid 13.8-rc-1 on Pixel 3 Android 10.

/hat tip @mchowning for the report, internal reference: p77Llu-c0a-p2
@jd-alexander jd-alexander self-assigned this Dec 17, 2019
@nikopetr
Copy link

@nikopetr nikopetr commented Dec 21, 2019

Hello is this still up ?
@shiki
Copy link
Member

@shiki shiki commented Jan 17, 2020

@jd-alexander Are you still working on this? If not, maybe @nikopetr can take a look?
@jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Jan 17, 2020

@shiki Yes, I am going to do look at this one and the other.
@jd-alexander jd-alexander removed their assignment Jan 17, 2020
@A-L-Fearon
Copy link
Contributor

@A-L-Fearon A-L-Fearon commented Aug 17, 2020

Howdy @jd-alexander, is this issue still available ?
@jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Aug 18, 2020

@A-L-Fearon yes it is.
@Bawya1098
Copy link

@Bawya1098 Bawya1098 commented Aug 18, 2020 •
edited

@jd-alexander. Hello, I would like to Contribute and work on this.
Could you please help me with the authentication part?
@jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Aug 18, 2020

Hi @Bawya1098 Thanks for volunteering to contribute. We really appreciate it 😄

Could you please help me with the authentication part?

Could you expound a bit on the issues you are having? Thank you.
@A-L-Fearon
Copy link
Contributor

@A-L-Fearon A-L-Fearon commented Aug 18, 2020

@jd-alexander thanks for the response, was inquiring to take this on but @Bawya1098 beat me to it 😅
@Bawya1098
Copy link

@Bawya1098 Bawya1098 commented Aug 19, 2020

@jd-alexander, I was not clear with the OAuth2 Authentication,
I'm able to build it locally but not able to login.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Site Settings TalkBack [Type] Bug good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@shiki @designsimply @jd-alexander @A-L-Fearon @nikopetr @Bawya1098
You can’t perform that action at this time.