Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Swift 4.2] Updated QuickSort #812
Merged
Conversation
laurentaylormarshall
changed the title
|
One small comment but otherwise looks good. Thanks for the update! |
| if i>=j { | ||
| return | ||
| } | ||
| func slowSort(_ i: Int, _ j: Int, _ numberList: inout [Int]) { |
richard-ash
Oct 26, 2018
Contributor
Mind updating the indentation to 2 spaces? This function seems to be indented at 4 spaces.
Mind updating the indentation to 2 spaces? This function seems to be indented at 4 spaces.
laurentaylormarshall
Oct 26, 2018
Author
Contributor
It's just in the README and it appears fine.
It's just in the README and it appears fine.
kelvinlauKL
Nov 28, 2018
Member
@laurentaylormarshall We have a convention where all code should be indented for 2-spaces, that example uses 4 spaced indents.
@laurentaylormarshall We have a convention where all code should be indented for 2-spaces, that example uses 4 spaced indents.
richard-ash
merged commit 82494bf
into
raywenderlich:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Checklist
Description
Updates the build settings to build with Swift 4.2 and removes the references to checking for Swift 4.0.