Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update FS examples to use Arduinojson 6 (Fixes #1059) #1060
Conversation
|
I thought this was already done.. |
|
There is an open PR but it doesn't cover both example files (and seems to change a lot of unrelated code too...) |
|
It seems to be fixed in hotfixes, not sure if I ever merged into master. Either way it needs to be fixed in development branch also, not sure if I will be able to merge them without conflicts , ill check also Let me look into the branches and see whats up, maybe that pr just missed some, ill try to clean them up today, thanks! |
|
No worries! I left the development branch examples alone because it seems like they're not finalised yet |
|
Yup it looks like I never made a release for the hotfixes changes, shoot. Sorry about that, ill double check which one is better and merge them, thanks |
|
I changed your target to hotfixes, here is the conflicts with what was already committed, I asked that that one be backward compatible, let me know if something is missing, we can probably just skip your PR, sorry to waste your time. I appreciate it. |
|
Yeah, that previous PR looks fine to me. The only thing is whether we use Static or Dynamic JSON documents, and what size they are, but ultimately this is example code so it's up to the end user. |
|
Resolved conflicts and slightly tidied up |
Small direct updates to change the AutoConnectWithFSParameters and AutoConnectWithFSParametersAndCustomIP examples to make them compatible with Arduinojson 6
Fixes #1059