close
The Wayback Machine - https://web.archive.org/web/20230213161928/https://github.com/responsively-org/responsively-app/issues/531
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't disable spell checker when or after using dev tools #531

Closed
XVonRad opened this issue Nov 7, 2020 · 5 comments · Fixed by #545
Closed

Can't disable spell checker when or after using dev tools #531

XVonRad opened this issue Nov 7, 2020 · 5 comments · Fixed by #545
Labels
enhancement New feature or request
Projects
Milestone

Comments

@XVonRad
Copy link

XVonRad commented Nov 7, 2020

🐞 bug report

✍️ Description

My page has non-english words. The spell checker is activated as soon as I open dev tools. The red squiggly red lines under unrecognized words ruin the page rendering. From then on only a full refresh will deactivate the spell checker.

✄1�7 Describe the solution you'd like

A setting where spell check can be turned on and off

✍️ Describe alternatives you've considered

Disabling spell checking at OS level (Windows 10 in my case).

🕵🏼‍♂︄1�7 Is this a regression?

🔬 Minimal Reproduction

See description

🌍 Your Environment

Windows 10

🔥 Exception or Error or Screenshot

@open-collective-bot
Copy link

Hey @XVonRad 👋,

Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.

https://opencollective.com/responsively

PS.: We offer priority support for all financial contributors. Don't forget to add priority label once you start contributing 😄

@jjavierdguezas jjavierdguezas added awaiting triage Needs debugging to know the root cause more info needed Need more details about the issue labels Nov 8, 2020
@jjavierdguezas
Copy link
Contributor

Hi @XVonRad , can you please share a screenshot, gif or video showing the issue?

@jjavierdguezas
Copy link
Contributor

jjavierdguezas commented Nov 8, 2020

Maybe we can play around with the spellcheck prop of BrowserWindow and webview (webpreferences)
https://www.electronjs.org/docs/tutorial/spellchecker

win = new BrowserWindow({
  spellcheck: false,
  .....
});



<webview
    webpreferences="spellcheck=no"
    ....
/>

@XVonRad
Copy link
Author

XVonRad commented Nov 8, 2020

Hi @XVonRad , can you please share a screenshot, gif or video showing the issue?

Responsively 2020-11-08 16-09-15.zip

Hi @jjavierdguezas
I've uploaded a screen video showing that once I've click Enable Design Mode, the spell checker activates and stays on after I disable Design Mode.
Note: I never even wanted to enter design mode actually. It's just that I more often than not click on it because it's so close to 'Inspect Element' . If the button bar layout was different I'd probably never have had this issue!

@jjavierdguezas
Copy link
Contributor

I see it now @XVonRad .. yes I think that a toggle in user preferences to activate/deactivate spell checker will be useful

@jjavierdguezas jjavierdguezas added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed and removed awaiting triage Needs debugging to know the root cause more info needed Need more details about the issue labels Nov 10, 2020
@jjavierdguezas jjavierdguezas added this to New in App Roadmap via automation Nov 10, 2020
@jjavierdguezas jjavierdguezas moved this from New to Accepted in App Roadmap Nov 10, 2020
@jjavierdguezas jjavierdguezas moved this from Accepted to In PR in App Roadmap Feb 1, 2021
@manojVivek manojVivek moved this from In PR to Ready for Release in App Roadmap May 9, 2021
@manojVivek manojVivek added this to the v0.16.0 milestone May 9, 2021
@manojVivek manojVivek removed good first issue Good for newcomers help wanted Extra attention is needed labels May 9, 2021
@manojVivek manojVivek moved this from Ready for Release to Release v0.16.0 in App Roadmap May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
App Roadmap
  
Release v0.16.0
Development

Successfully merging a pull request may close this issue.

3 participants