close
The Wayback Machine - https://web.archive.org/web/20200927060444/https://github.com/buzzfeed/sso/issues/82
Skip to content

/ sso

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sso-proxy: remove provider interface #82

Open
shrayolacrayon opened this issue Oct 4, 2018 · 3 comments
Open

sso-proxy: remove provider interface #82

shrayolacrayon opened this issue Oct 4, 2018 · 3 comments
Labels
chore good first issue

Comments

@shrayolacrayon
Copy link
Contributor

@shrayolacrayon shrayolacrayon commented Oct 4, 2018 •
edited by mreiferson

What

This is something that was not changed from the original oauth_proxy clone that can be removed.
Since we only have one provider for sso-proxy - the SSOProvider, to simplify testing and remove default provider logic, it makes sense to get rid of the interface and have the OAuthProxy struct's provider field be an SSOProvider rather than a Provider interface.
@shrayolacrayon shrayolacrayon self-assigned this Oct 4, 2018
@luisdavim
Copy link

@luisdavim luisdavim commented Oct 18, 2018

won't this block #27 ?
@shrayolacrayon
Copy link
Contributor Author

@shrayolacrayon shrayolacrayon commented Oct 22, 2018

This is specifically to remove the provider interface (or consolidate both provider interfaces into one) in sso-proxy. This was something that we have yet to clean up from when we began development from starting off with using oauth2_proxy. sso-proxy's only provider is sso-auth and sso-auth uses a third party authenticator defined by a provider interface. #27 refers to sso-auth's third-party providers.
@luisdavim
Copy link

@luisdavim luisdavim commented Oct 22, 2018

Makes sense, thanks for explaining that.
@desimone desimone mentioned this issue Jan 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@luisdavim @mreiferson @shrayolacrayon
You can’t perform that action at this time.